hono/cloudflare-pages 404 handler doesn't work

[Skye-31]

As shown in the snippet below, when using hono's cloudflare pages handler, it doesn't inherit the 404 handler of the original app, so it responds with Hono's generic plaintext 404 (thanks to new Hono().route(...))

export const onRequest = handle(app, '/api');

hono/src/adapter/cloudflare-pages/handler.ts

Lines 17 to 22 in fea78f2

	export const handle: HandleInterface =
	<E extends Env>(subApp: Hono<E>, path?: string) =>
	({ request, env, waitUntil }) => {
	const app = path ? new Hono<E>().route(path, subApp) : subApp
	return app.fetch(request, env, { waitUntil, passThroughOnException: () => {} })
	}

[yusukebe]

Hi @Skye-31 !

Yes, you are right. app.route() does not inherit the Not Found handler of "subApp". So we were about to deprecate passing the path as the second argument. Instead, we will recommend specifying base path with the basePath method:

const app = new Hono().basePath('/api')

//...

export const onRequest = handle(app)

This feature is not merged #964 , but it will be merged soon! We will write about that in the documentation after releasing.

Thank you for the issue.