-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent msrv change should have been in a minor release instead of a patch #151
Comments
that's a shame, thanks for the notice. What about using the dbus feature for this use case? zbus is always a bit "bleeding edge" in regard to MSRV, that's why I kept the old dbus-rs implementation around. |
Even if we would fallback to using My personal suggestion would be, to stay on a |
since this is a reoccurring issue, do you know of any way we could check this debian compatibility in CI, other than continuously checking which rust version is packaged with debian? |
I'll revert the set I would therefore try to keep compatible with zbus's latest requirements in CI (setting the rust version to 1.60) but keep the dbus version around and have it determine the cargo.toml |
Problem
With the recent version v4.5.9, the MSRV for
notify-rust
has been raised to 1.60 in react to bumpingzbus
to v3 which requires rust 1.60, but this caused downstream apps to break on older rust version unexpectedly. MSRV should have been in a minor release at least if not major.Having a MSRV 1.60 also means that you can't submit any app that depends on it to debian store since debian only has 1.59.
What is the solution?
notify-rust
should revert thezbus
bump, revert the MSRV to the version it was before and release a patch release. If you still want to usezbus@v3
then it should be bumped in a minor release or stay onzbus@v2
until 1.60 is available in debianThe text was updated successfully, but these errors were encountered: