Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivative incorrect calculation #2

Open
kisdma opened this issue Feb 14, 2020 · 0 comments
Open

Derivative incorrect calculation #2

kisdma opened this issue Feb 14, 2020 · 0 comments

Comments

@kisdma
Copy link

kisdma commented Feb 14, 2020

The first derivative has an incorrect sign. The higher derivatives also need to be multiplied by factorial(n)*(-1)^n. Or c matrix need to be flipud'ed instead of (-1)^n (even columns are symmetric anyways).

This issue is very easy to see using the provided example with noisy sin function.

I hope this is clear - let me know please. I can incorporate these changes myself in a fork and you could merge - if you like this way better.

Anyway, thanks for this great code, author! I hope this will help to make it perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant