Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE 621: Configuration to disable schema auto creation by the client #622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gmcoringa
Copy link

This pr address #621

@gmcoringa gmcoringa changed the title Configuration to disable schema auto creation by the client ISSUE 621: Configuration to disable schema auto creation by the client Nov 13, 2019
@raju-saravanan
Copy link
Collaborator

@gmcoringa Thanks for raising this PR. I have a couple of questions, may I know how this change is going to address your use case? If "schema.auto.create" is disabled then the lastest schema version is being utilized to serialize the data, this would only work if the schemas are backward compatible or fully compatible.

@gmcoringa
Copy link
Author

@raju-saravanan we have some problems with the latest version when the client tries to get the schema to perform the serialization, because some avro schemas wasn't compatible with the latest avro version (1.9.1)

One of them was because the get actually calls addSchemaVersion. This PR tries to address this problem and for us its a good solution because the creation of schemas are done through schema-registry ui with backward compatibility.

Meanwhile we fixed this problem using an older version of schema-registry and fixing all the incompatible avro schemas, but this wasn't enough, because the call to addSchemaVersion perform a validation against all schema versions, due the default validation level ALL, which we fixed updating all schemas with the validation level LATEST.

Actually this PR isn't needed anymore, so if you think that do not fit in schema registry design, feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants