Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HandlerConfigInterface fluent in the next major release #58

Open
vudaltsov opened this issue Feb 13, 2018 · 2 comments
Open

Make HandlerConfigInterface fluent in the next major release #58

vudaltsov opened this issue Feb 13, 2018 · 2 comments

Comments

@vudaltsov
Copy link

I read this article https://ocramius.github.io/blog/fluent-interfaces-are-evil/, I agree that in most cases fluent interfaces are not good.

But configurator by nature is not supposed to return anything. So it can be either : void or : self. I think that fluent interface is more convenient as it gives you both usage possibilities.

@iltar , what do you think?

@yannickl88
Copy link
Member

yeah, not sure why we didn't make it fluid in the first place... You have my vote!

@linaori
Copy link
Contributor

linaori commented Feb 13, 2018

I'm not necessarily opposed to having it, but I wouldn't use it if you write unit-tests with mocks/prophecies. You'll have to define a willReturn every single time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants