-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify project grid map stylings #829
base: master
Are you sure you want to change the base?
Conversation
Thanks for the proposed PR. |
I like it too. Thanks for the initial work @althio. The only color I'm not super happy with is the pink for invalidated. I've no other suggestion though. |
6e49cd1
to
56b07a5
Compare
Yeah |
I don't like stoplight (red/yellow/green) for several reasons:
On the other hand I agree:
But the other way round: we choose colors for the map tiles and legend, and then we match the styling of the buttons with the map tiles. |
Hi @ethan-nelson, the purple variation is hard to judge directly from the picture, because of the outline which can create optical illusion. TL;DR: 'purple' #800080 and 'mediumorchid' #ba55d3 are close enough, one is darker, other is lighter. I have no call on this, other than both are valid for me. I value more the feedback of others and your input, especially regarding color blindness and cultural signification of colors. Long story and some background: I wanted to keep current 'green' and 'orange', they are well-established and well-adapted. The level of saturation and value/lightness/brightness of my 'purple' / 'pale purple' was chosen arbitrarily as far as I can remember, to match the level of visual impact from 'green' and 'orange' and the fact that Invalidated tiles are not very common, and should not stand out for beginners. Than I looked for the closest hmtl-code websafe color, and ended up with 'mediumorchid', hence the proposal for this particular color. schemes with green (note that 'green' and 'purple' are direct opposites, complementary colors) |
Reviving the discussion from #500, here are changes to make different states on the map a little more visible. Here's an example of the map:
Comments? The other option may be to explore the leaflet plugin for fill patterns, but that my be a bit overkill.