Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review admin: approve all reviews button #70

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Review admin: approve all reviews button #70

wants to merge 5 commits into from

Conversation

nathanmsmith
Copy link
Member

Description

Deployment

  • I am making a frontend change, which will be auto-deployed via Heroku.
  • I am making a Ruby change, which will be auto-deployed via Heroku.
    • I have added one or more gems, and run rake sorbet:update:all to generate their types.
    • I have added or changed a model, and run rake sorbet:update:all to generate their types.
  • I am making a database change, which I will manually deploy after my branch is merged.
    • I have migrated the database using env RAILS_ENV=production rails db:migrate.
    • I have updated the entity relationship diagram via bundle exec erd.
    • I have updated the affected Administrate model dashboards to reflect my DB changes.
  • I am making a Go Lambda change, which I will manually deploy after my branch is merged.
    • I have deployed the lambdas using make deploy.
  • There are other deployment steps I must take after merge, which are:

@nathanmsmith nathanmsmith changed the title Review admin: approve all reviews Review admin: approve all reviews button Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nathanmsmith