Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in login process #258

Closed
ravilodhi opened this issue Feb 6, 2024 · 3 comments
Closed

Fix error handling in login process #258

ravilodhi opened this issue Feb 6, 2024 · 3 comments
Assignees
@amansinghbais @Adameddy26
Labels
bug Something isn't working

Comments

@ravilodhi
Copy link
Contributor

Currently, most of the OMS APIs return an error object in case of failure. However, the error is treated as a string in error handling. Please enhance the error handling to consider both the error pattern so that messages like [object, object] can be avoided.
Screenshot from 2024-02-06 11-08-25
@amansinghbais amansinghbais moved this to 🏗 In progress in Digital Experience Platform Feb 6, 2024
@amansinghbais amansinghbais mentioned this issue Feb 6, 2024
Merged
1 task
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 6, 2024
@amansinghbais amansinghbais mentioned this issue Feb 6, 2024
Merged
1 task
This was referenced Feb 7, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
@Adameddy26 Adameddy26 added the bug Something isn't working label Mar 11, 2024
@Adameddy26 Adameddy26 moved this from 👀 In review to 🛠 In QA in Digital Experience Platform Mar 13, 2024
@Adameddy26 Adameddy26 moved this from 🛠 In QA to 📋 Backlog in Digital Experience Platform Mar 13, 2024
@Adameddy26
Copy link

Adameddy26 commented Mar 13, 2024 •
edited
Loading

Issue verified in fulfillment app release v2.0.3 and found that issue is not fixed properly.

Screenshot 2024-03-13 at 4 42 29 PM

@Adameddy26
Copy link

Verified this issue for import app release v2.15.0 and found that issue is working fine.
Uploading Screenshot 2024-03-19 at 4.45.13 PM.png…

@Adameddy26 Adameddy26 self-assigned this Mar 19, 2024
@Adameddy26 Adameddy26 moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Mar 19, 2024
@Adameddy26
Copy link

Issue verified and working fine in facilities app release v1.5.0.

@amansinghbais amansinghbais mentioned this issue Jul 10, 2024
Merged
1 task
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jul 10, 2024
@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amansinghbais amansinghbais

@Adameddy26 Adameddy26

Labels
bug Something isn't working
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ravilodhi @ymaheshwari1 @amansinghbais @Ritika-Patel08 @Adameddy26