Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed fab position adjustment and decreased value of bottom position of scan button (#2401fr1) #51

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Removed fab position adjustment and decreased value of bottom position of scan button (#2401fr1) #51

merged 2 commits into from
Jan 21, 2022

Conversation

azkyakhan
Copy link
Contributor

@azkyakhan azkyakhan commented Jan 21, 2022 •
edited
Loading

Related Issues

Closes #

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

  • I read and followed contribution rules
  • I have changed the target to hacktoberfest branch

@azkyakhan
Copy link
Contributor Author

fab-button-adjustment.mp4

@azkyakhan
Copy link
Contributor Author

I have decreased the value of position bottom value of scan button on search page because as I removed fullscreen property from ion-content of app.vue, the scan button moved a little upwards, that is why I decreased its bottom value.

@azkyakhan azkyakhan requested a review from dt2patel January 21, 2022 17:10
dt2patel
dt2patel approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@dt2patel dt2patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dt2patel dt2patel merged commit 828159f into hotwax:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt2patel dt2patel dt2patel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azkyakhan @dt2patel