Implemented: logic to select location on product detail page (#22qm8pq). #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h and store location detail on 'count.vue' page (#22qm8pq).
src/views/count.vue
Outdated
| methods: { | ||
| async openLocationPicker() { |
There was a problem hiding this comment.
Suggested change
| async openLocationPicker() { | |
| async selectLocation() { |
There was a problem hiding this comment.
Changed method name.
adityasharma7
suggested changes
Mar 9, 2022
src/views/count.vue
Outdated
| "entityName": "ProductFacilityLocation", | ||
| "fieldsToSelect": [ "locationSeqId" ] | ||
| } | ||
| resp = await UserService.getFacilityLocations(params); |
There was a problem hiding this comment.
Suggested change
| resp = await UserService.getFacilityLocations(params); | |
| resp = await ProductService.getFacilityLocations(params); |
There was a problem hiding this comment.
Changed Service name.
src/views/count.vue
Outdated
| }, | ||
| { | ||
| text: translate('Confirm'), | ||
| handler: (value) => { |
There was a problem hiding this comment.
Suggested change
| handler: (value) => { | |
| handler: (data) => { |
There was a problem hiding this comment.
Changed parameter name.
adityasharma7
suggested changes
Mar 10, 2022
src/views/count.vue
Outdated
| this.facilityLocations = this.facilityLocations.map((location: any) => { | ||
| return { | ||
| locationSeqId: location.locationSeqId, | ||
| locationLabel: location.areaId + location.aisleId + location.sectionId + location.levelId + location.positionId |
There was a problem hiding this comment.
Suggested change
| locationLabel: location.areaId + location.aisleId + location.sectionId + location.levelId + location.positionId | |
| location: location.areaId + location.aisleId + location.sectionId + location.levelId + location.positionId |
src/views/count.vue
Outdated
| <ion-item> | ||
| <ion-label>{{ $t("Location") }}</ion-label> | ||
| <ion-chip @click="selectLocation"> | ||
| <ion-label>{{ locationId }}</ion-label> |
There was a problem hiding this comment.
Suggested change
| <ion-label>{{ locationId }}</ion-label> | |
| <ion-label>{{ location }}</ion-label> |
…n method (#22qm8pq).
…nt.vue file (#22qm8pq)
meet-aniket
changed the title
… data (#22qm8pq).
adityasharma7
changed the title
adityasharma7
suggested changes
Mar 23, 2022
changelogs/unreleased/-22qm8pq.yml
Outdated
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| title: 'Impelented: logic to select location on pdp page' | |||
There was a problem hiding this comment.
Suggested change
| title: 'Impelented: logic to select location on pdp page' | |
| title: 'Implemented: logic to select location on product detail page' |
There was a problem hiding this comment.
Improved title of the changelog.
src/views/count.vue
Outdated
| methods: { | ||
| async selectLocation() { | ||
| this.pickerOptions = await this.facilityLocations.map((location: any) => { |
There was a problem hiding this comment.
I think we could make pickerOptions local variable instead
adityasharma7
suggested changes
Mar 23, 2022
adityasharma7
suggested changes
Mar 24, 2022
adityasharma7
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.