Fixed: Set keyboard type for stock input field(#2cqz21c) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt2patel
approved these changes
May 18, 2022
src/views/count.vue
Outdated
| @@ -36,7 +36,7 @@ | |||
| </div> | |||
| <ion-item> | |||
| <ion-label position="floating">{{ $t("Stock") }}</ion-label> | |||
| <ion-input v-model="product.quantity"></ion-input> | |||
| <ion-input inputmode="numeric" v-model="product.quantity"></ion-input> | |||
There was a problem hiding this comment.
I think we could change type to number as well. @dt2patel WDYT?
There was a problem hiding this comment.
makes sense. then we should also set min value as well
There was a problem hiding this comment.
OK, Sir, I will fix it.
dt2patel
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
when the user selects the stock input field, the system keyboard should be a number pad
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance