Updated Readme file and added pull request template(#2q9nxqt) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymaheshwari1
requested changes
Aug 16, 2022
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| ### Contribution and Currently Important Rules Acceptance | ||
| <!-- Please get familiar with following info --> | ||
|
|
||
| - [ ] I read and followed [contribution rules](https://github.com/DivanteLtd/vsf-capybara/blob/master/CONTRIBUTING.md) |
There was a problem hiding this comment.
Update this link to admin-helper repo.
.github/workflows/pull-request.yml
Outdated
| push: | ||
| pull_request: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Suggested change
| - master | |
| - main |
There was a problem hiding this comment.
Replaced master with main
README.md
Outdated
| 1. Download the app from [release](https://github.com/hotwax/shopify-admin-helper/releases) page and extract it. | ||
| 2. Go to the app directory. | ||
| 3. Run following command to download dependencies | ||
| `npm i |
There was a problem hiding this comment.
Suggested change
| `npm i | |
| `npm i` |
There was a problem hiding this comment.
Added missing quote
README.md
Outdated
| 3. Create a branch for your edits. Use the following branch naming conventions: **shopify-admin-helper/issue-number**. | ||
| 4. Please add issue number to your commit message. | ||
| 5. Propose a Pull Request to `main` branch containing issue number and issue title. | ||
| 6. Use [Pull Request template](https://github.com/hotwax/preorder/blob/main/.github/PULL_REQUEST_TEMPLATE.md) (it's automatically added to each PR) and fill as much fields as possible to describe your solution. |
README.md
Outdated
| If you have any questions or ideas feel free to join our <a href="https://discord.gg/SwpJnpdyg3" target="_blank">Discord channel</a> | ||
| # The license | ||
|
|
||
| Pre-order app is completely free and released under the Apache v2.0 License. Check <a href="https://github.com/hotwax/shopify-admin-helper/blob/main/LICENSE" target="_blank">LICENSE</a> for more details. |
There was a problem hiding this comment.
Suggested change
| Pre-order app is completely free and released under the Apache v2.0 License. Check <a href="https://github.com/hotwax/shopify-admin-helper/blob/main/LICENSE" target="_blank">LICENSE</a> for more details. | |
| Shopify Admin Helper app is completely free and released under the Apache v2.0 License. Check <a href="https://github.com/hotwax/shopify-admin-helper/blob/main/LICENSE" target="_blank">LICENSE</a> for more details. |
There was a problem hiding this comment.
Improved app name
azkyakhan
changed the title
azkyakhan
changed the title
adityasharma7
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.