From 50852c3879d57a521e8b605cf3ac965d9dc91885 Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Fri, 8 Mar 2024 18:40:19 +0530
Subject: [PATCH] Improved: added the permision check for the security group
 create and permission association action(#158)

---
 src/authorization/Actions.ts       | 1 +
 src/authorization/Rules.ts         | 1 +
 src/components/PermissionItems.vue | 5 ++++-
 src/views/Permissions.vue          | 5 ++++-
 4 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/authorization/Actions.ts b/src/authorization/Actions.ts
index dfa5ae0..480ea79 100644
--- a/src/authorization/Actions.ts
+++ b/src/authorization/Actions.ts
@@ -6,5 +6,6 @@ export default {
   'APP_UPDT_PRODUCT_STORE_CONFG': 'APP_UPDT_PRODUCT_STORE_CONFG',
   'APP_SUPER_USER': 'APP_SUPER_USER',
   'APP_SECURITY_GROUP_CREATE': 'APP_SECURITY_GROUP_CREATE',
+  'APP_PERMISSION_UPDATE': 'APP_PERMISSION_UPDATE',
   'APP_USER_CREATE': 'APP_USER_CREATE'
 }
\ No newline at end of file
diff --git a/src/authorization/Rules.ts b/src/authorization/Rules.ts
index c1ff6f7..cd9a28d 100644
--- a/src/authorization/Rules.ts
+++ b/src/authorization/Rules.ts
@@ -6,6 +6,7 @@ export default {
   'APP_UPDT_PASSWORD': 'SECURITY_CREATE OR SECURITY_ADMIN',
   'APP_UPDT_PRODUCT_STORE_CONFG': 'SECURITY_CREATE OR SECURITY_ADMIN',
   'APP_SECURITY_GROUP_CREATE': 'SECURITY_CREATE OR SECURITY_ADMIN',
+  'APP_PERMISSION_UPDATE': 'SECURITY_CREATE OR SECURITY_ADMIN',
   'APP_SUPER_USER': 'WEBTOOLS_VIEW',
   'USERS_APP_VIEW': 'USERS_APP_VIEW'
 } as any
\ No newline at end of file
diff --git a/src/components/PermissionItems.vue b/src/components/PermissionItems.vue
index 3aea1ef..63e1a43 100644
--- a/src/components/PermissionItems.vue
+++ b/src/components/PermissionItems.vue
@@ -23,7 +23,7 @@
               <ion-card-title>{{ permission.permissionId }}</ion-card-title>
               <ion-card-subtitle>{{ getPermissionDescription(permission.permissionId) }}</ion-card-subtitle>
             </div>
-            <ion-checkbox :checked="permission.isChecked" @click="updatePermissionAssociation($event, permission)" />
+            <ion-checkbox :disabled="!hasPermission(Actions.APP_PERMISSION_UPDATE)" :checked="permission.isChecked" @click="updatePermissionAssociation($event, permission)" />
           </ion-card-header>
         </ion-card>
       </section>
@@ -58,6 +58,7 @@ import { PermissionService } from '@/services/PermissionService';
 import { showToast } from '@/utils';
 import { hasError } from '@/adapter';
 import { DateTime } from 'luxon';
+import { Actions, hasPermission } from '@/authorization'
 
 export default defineComponent({
   name: 'PermissionItems',
@@ -150,6 +151,8 @@ export default defineComponent({
     const store = useStore();
 
     return {
+      Actions,
+      hasPermission,
       shieldCheckmarkOutline,
       store,
       translate
diff --git a/src/views/Permissions.vue b/src/views/Permissions.vue
index 6cc90f1..f7e36cb 100644
--- a/src/views/Permissions.vue
+++ b/src/views/Permissions.vue
@@ -25,7 +25,7 @@
             </ion-item>
           </ion-list>
 
-          <ion-button @click="createGroup()" fill="clear" expand="block">
+          <ion-button @click="createGroup()" :disabled="!hasPermission(Actions.APP_SECURITY_GROUP_CREATE)" fill="clear" expand="block">
             <ion-icon slot="start" :icon="addOutline" />
             <ion-label>{{ translate("Create security group") }}</ion-label>
           </ion-button>
@@ -86,6 +86,7 @@ import emitter from "@/event-bus";
 import { PermissionService } from '@/services/PermissionService';
 import { DateTime } from 'luxon';
 import EditSecurityGroupModal from '@/components/EditSecurityGroupModal.vue';
+import { Actions, hasPermission } from '@/authorization'
 
 export default defineComponent({
   name: 'Permissions',
@@ -254,8 +255,10 @@ export default defineComponent({
     const store = useStore();
 
     return {
+      Actions,
       addOutline,
       downloadOutline,
+      hasPermission,
       idCardOutline,
       openOutline,
       router,