Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page refreshes: Selected option issue when morphing with changing select options #1119

Closed
meceo opened this issue Jan 1, 2024 · 5 comments
Closed

Comments

@meceo
Copy link

meceo commented Jan 1, 2024

"Selected option" gets incorrectly displayed once server side returns new select options using morphing. After morphing the DOM contains the correct option with "selected" tag, but displayed one is incorrect. When forcing page refresh the selected option is properly displayed.

morph issue

Minimalistic code to reproduce the issue:
https://github.com/meceo/morph_testing/pull/2/files

@brunoprietog
Copy link
Collaborator

This is a bug in Idiomorph that has been fixed in the latest version. We need to bring these changes to Turbo

@meceo
Copy link
Author

meceo commented Jan 12, 2024

@brunoprietog do you already know when the changes will be bring to Turbo? Can I help?

@brunoprietog
Copy link
Collaborator

It was made in #1122 and is now in main. It would be great if you can test if that solves the problem. If it doesn't, we should report this to Idiomorph.

@meceo
Copy link
Author

meceo commented Jan 13, 2024

@brunoprietog I tested the main branch and it looks good.

CleanShot 2024-01-13 at 16 13 24

@brunoprietog
Copy link
Collaborator

Great! So can you close this?

@meceo meceo closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants