fix: comment out income validation and change to text field #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for housing-sanjoseca-gov ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for hba-public-main ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ludtkemorgan
added a commit
that referenced
this pull request
Jun 14, 2023
* feat: upgrading typeorm (bloom-housing#3340) * feat: upgrading typeorm * fix: updates for tests * fix: updating nestjs packages, clean up per morgan * fix: undoing nestjs bump * fix: missed changes * fix: minor typeorm version update * fix: user update per sean * fix: listings update per sean * fix: test updates * fix: hopefully resolves failing build on heroku * fix: attempt 2 on fixing heroku deploy * fix: updates * fix: update throttling in tests * fix: asset test fix * fix: updates for images and multiselect * fix: update for mfa * fix: type fix * fix: another type fix * fix: update for partner test * fix: issue with jurisdiction resolver service * fix: test fixes * fix: fix for mfa tests? * fix: attempt at mfa test fix * fix: remove listing service from afs cron job (bloom-housing#3428) * fix: update for tests * fix: fix for dup resolution --------- Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Morgan Ludtke <42942267+ludtkemorgan@users.noreply.github.com> * fix: upgrade all nest dependencies (bloom-housing#3461) * fix: add additional unit fields to base view (bloom-housing#3492) * Revert "fix: comment out income validation and change to text field (#620)" This reverts commit f56fdad. --------- Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com> Co-authored-by: Sean Albert <smabert@gmail.com>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
Support issue Slack thread
Description
This is a temporary fix that we hope will allow folks to continue past the income step. It removes all validation on the field, but does still require it.
How Can This Be Tested/Reviewed?
Try to submit an application with non-numeric characters + numbers that are well above and below the listing's limits.
In partners it should display as that string.
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.