Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button "Speichern" (Submit) in setting screens very small + label missing #568

Closed
CaCu15 opened this issue Dec 30, 2023 · 2 comments · Fixed by #569
Closed

Button "Speichern" (Submit) in setting screens very small + label missing #568

CaCu15 opened this issue Dec 30, 2023 · 2 comments · Fixed by #569
Labels
bug Something isn't working

Comments

@CaCu15
Copy link

CaCu15 commented Dec 30, 2023

What happened?

Just upgraded to the release 2023.12.27.post1.

Everything works fine, but in the settings screen the button to submit the changes is VERY small, only a small blue area without any label. See attached screenshot. The button still works, you can save the settings, thus it is only a minor visual issue.

Happens in the follwing screens:

  • VE Direct settings
  • Power meter settings
  • Dynamic Power Limiter settings
  • Battery settings
  • AC Charger settings

grafik

To Reproduce Bug

Open any settings dialog listed above

Expected Behavior

Button should look like in the other setting screens and should be labeled "Speichern" (in the German version)

Install Method

Pre-Compiled binary from GitHub

What git-hash/version of OpenDTU?

2023.12.27.post1

Relevant log/trace output

No response

Anything else?

No response

@CaCu15 CaCu15 added the bug Something isn't working label Dec 30, 2023
@schlimmchen
Copy link
Member

schlimmchen commented Dec 30, 2023

Tatsächlich. Dass das nur OpenDTU-OnBattery-spezifische Seiten sind, ist sicherlich kein Zufall... Ich denke das Problem ist schnell gefunden.

Im Upstream-Projekt wurde der FormFooter (eine Vue Komponente) eingeführt. Die verwendet nun den Text aus base.Save und base.Cancel. Die OpenDTU-OnBattery-spezifischen Seiten sollten ebenfalls auf den FormFooter umgestellt werden. Ich bereite einen PR vor.

Copy link

github-actions bot commented Apr 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants