--with-lustre fails due to _XOPEN_SOURCE

[glennklockwood]

It looks like #110 broke the Lustre support in IOR:

$ ./configure --with-lustre --without-gpfs
checking metadata... yes
checking build system type... x86_64-suse-linux-gnu
...
checking lustre/lustre_user.h usability... no
checking lustre/lustre_user.h presence... yes
configure: WARNING: lustre/lustre_user.h: present but cannot be compiled
configure: WARNING: lustre/lustre_user.h:     check for missing prerequisite headers?
configure: WARNING: lustre/lustre_user.h: see the Autoconf documentation
configure: WARNING: lustre/lustre_user.h:     section "Present But Cannot Be Compiled"
configure: WARNING: lustre/lustre_user.h: proceeding with the compiler's result
checking for lustre/lustre_user.h... no
configure: error: in `/global/homes/g/glock/src/git/ior-dev/build':
configure: error: --with-lustre was given, <lustre/lustre_user.h> not found
See `config.log' for more details

where config.log shows

configure:5477: checking lustre/lustre_user.h usability
configure:5477: cc -std=gnu99 -c -g -O2  conftest.c >&5
In file included from /usr/include/lustre/lustre_user.h(59),
                 from conftest.c(89):
/usr/include/sys/quota.h(221): error: identifier "caddr_t" is undefined
             caddr_t __addr) __THROW;
             ^

compilation aborted for conftest.c (code 2)

This is a result of caddr_t being explicitly undefined for _XOPEN_SOURCE (see pmodels/mpich#1973).

We might have to undo #110 and put it back into only those source files which need it. Any objections?

(note: this does not affect version 3.2.0 since these POSIX patches did not make it into that release)

[jasimmons1973]

This is a bug in Lustre. Patch https://review.whamcloud.com/#/c/37678 just landed to lustre. Do we need this for Lustre 2.12 LTS?

[glennklockwood]

I don't think it's worth backporting just for IOR personally.

[jasimmons1973]

We see this for other user applications as well. It is being backported to 2.12 LTS release

[JulianKunkel]

I believe this matter is now resolved.