Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma in comments of IOR scripts lead to failure #144

Closed
blastmaster opened this issue Apr 18, 2019 · 3 comments
Closed

Comma in comments of IOR scripts lead to failure #144

blastmaster opened this issue Apr 18, 2019 · 3 comments

Comments

@blastmaster
Copy link
Contributor

blastmaster commented Apr 18, 2019

Hi,
I've encountered a problem when using commas in comments in IOR scripts passed with the -f option.
It seems when a comma is in a comment leads to a failure and IOR complains about whats after the comma.

E.g. if I start IOR with the following script.

IOR Config

IOR START
     api=POSIX                   # use POSIX I/O 
     useO_DIRECT=1               # bypass I/O buffers
     intraTestBarriers=1         # barriers between open, read/write, and close
     numTasks=0                  # 0 means all tasks
     filePerProc=1               # 1 means each proc access a single file
     blockSize=20G               # gigabytes (64 GB) 
     transferSize=2M             # megabytes (2 MB) 
     writeFile=1
     readFile=1
     segmentCount=1              # number of segments in file
     verbose=0                   # lowest level of verbosity
RUN
IOR STOP

I get an error like this:

Syntax error in configuration options:  read/write

If I then delete the first comma after the "open" the error changes to

Syntax error in configuration options:  and close

If I finally also delete the last comma in the comment the script works well.

JulianKunkel added a commit that referenced this issue Apr 19, 2019
@JulianKunkel
Copy link
Collaborator

I incorporated the fix into the branch for the parsing as it is related. Now comments in lines are ignored; that means "#" ain't be a valid character for any option value which seems OK to me. Before IOR only ignored lines which start with a comment.

@glennklockwood
Copy link
Contributor

@blastmaster Please let us know if this fixes the issue for you and we'll merge it into master.

@blastmaster
Copy link
Contributor Author

The patch seems to fix the issue. Looking forward to see the patch in master. :)
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants