Feature verify mdtest #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbent
approved these changes
Aug 2, 2019
| @@ -682,9 +700,16 @@ void mdtest_read(int random, int dirs, const long dir_iter, char *path) { | |||
|
|
|||
| /* read file */ | |||
| if (read_bytes > 0) { | |||
| read_buffer[0] = 42; | |||
There was a problem hiding this comment.
What is 42? Can we make it an enum typedef or something?
There was a problem hiding this comment.
It is just to overwrite the read buffer with something that is not in the pattern. It just cannot be 0.
| for (k=0; k < size; k++) { | ||
| for (j = 0; j < iterations; j++) { | ||
| curr = all[(k*tableSize*iterations) | ||
| + (j*tableSize) + i]; |
There was a problem hiding this comment.
I wonder if these two lines should be combined. Doing so pushes beyond 80 chars on the line? Do we have a style guide for IOR coding conventions?
There was a problem hiding this comment.
Surely, that was all the code that existed, I did change the condition to simplify the code, next time, improve that pieces :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That branch allows to use the -X parameter for MDTest which verifies that the data read (with -e) is the expected pattern.
MDTest does already check that the bytes read are the right number of bytes, but not
(Note: build upon the feature-mdtest-timer branch)