Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature aiori #184

Merged
merged 5 commits into from
Sep 9, 2019
Merged

Feature aiori #184

merged 5 commits into from
Sep 9, 2019

Conversation

JulianKunkel
Copy link
Collaborator

Changes to aiori supporting sync #175, fixing #24, #177

Copy link
Collaborator

@johnbent johnbent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this but I would like to see phase_end return a time stamp to further reduce LOC and improve readability.

int check = test->backend->check_params(test);
if (check == 0){
ERR("The backend returned that the test parameters are invalid.");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach is fine by me instead of #177. Thanks for including this to fix that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants