Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS Driver: Update License & Align with 1.0 API changes #215

Merged
merged 1 commit into from
Feb 26, 2020
Merged

DAOS Driver: Update License & Align with 1.0 API changes #215

merged 1 commit into from
Feb 26, 2020

Conversation

mchaarawi
Copy link
Contributor

  • License should inherit from IOR License.
  • remove checksums from Array API
  • add DFS dir oclass option

Signed-off-by: Mohamad Chaarawi mohamad.chaarawi@intel.com

@JulianKunkel
Copy link
Collaborator

I'm having a little concern regarding the change of the license of an industry contribution that removes some rights previously granted. In the strict sense, Copyright:
"means whatever content the author created cannot be used or published by anyone else without the consent of the author.". Hence, could mean that Intel needs to agree before a TAR of this code is published somewhere.
I would welcome it if you'd be able to add a disclaimer underneath that allows the code to retain the GPL2 license which the general IOR code is.
I also ask others for their feedback before merging.

I do not see a problem with any change to actual code...

@mchaarawi
Copy link
Contributor Author

mchaarawi commented Feb 26, 2020

I'm having a little concern regarding the change of the license of an industry contribution that removes some rights previously granted. In the strict sense, Copyright:
"means whatever content the author created cannot be used or published by anyone else without the consent of the author.". Hence, could mean that Intel needs to agree before a TAR of this code is published somewhere.
I would welcome it if you'd be able to add a disclaimer underneath that allows the code to retain the GPL2 license which the general IOR code is.
I also ask others for their feedback before merging.

I do not see a problem with any change to actual code...

yes that was definitely not my intention. I made a mistake pushing under APL.
I'll add the disclaimer to retain the GPL2 license.

- License should inherit from IOR License.
- remove checksums from Array API
- add DFS dir oclass option

Signed-off-by: Mohamad Chaarawi <mohamad.chaarawi@intel.com>
@mchaarawi
Copy link
Contributor Author

I reproduced what other commercial contributors had under their driver. please let me know if there is still a concern.

@JulianKunkel JulianKunkel merged commit f5ecb9d into hpc:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants