-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added icc, ifort, iccifort 2016.0.109 files #1973
Conversation
Automatic reply from Jenkins: Can I test this? |
Jenkins: ok to test |
|
||
toolchain = {'name': 'dummy', 'version': 'dummy'} | ||
|
||
sources = ['parallel_studio_xe_2016_composer_edition_for_cpp_2016.0.109.tgz'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid copy-pasting the version number in multiple places, use the %(version)s
template instead (see also http://easybuild.readthedocs.org/en/latest/Writing_easyconfig_files.html#easyconfig-param-templates)
sources = ['parallel_studio_xe_2016_composer_edition_for_cpp_%(version)s.tgz']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, even better (also avoid hardcoding 2016
):
sources = ['parallel_studio_xe_`%(version_major)s_composer_edition_for_cpp_%(version)s.tgz']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DirkdeDraak: did you rename the tarball yourself after downloading?
Because when I download it, I get a tarball named parallel_studio_xe_2016_composer_edition_for_cpp.tgz
...
Of course, right now it's unclear what Intel will do with the next release, i.e. whether they'll properly version the tarball or not, or just stick to parallel_studio_xe_2016_composer_edition_for_cpp.tgz
and expect people not to run in trouble.
Maybe it makes sense to add a checksum, to make very sure the used tarball is the right one?
I get this as MD5:
f57a892fb494db3c80f20a88aa3e901f /apps/gent/source/i/icc/parallel_studio_xe_2016_composer_edition_for_cpp.tgz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I renamed it,while it doesn't have a proper version number.
I have the same md5:
f57a892fb494db3c80f20a88aa3e901f parallel_studio_xe_2016_composer_edition_for_cpp_2016.0.109.tgz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, I'm not sure what the best long term approach is here, but for now, I'd stick to the 'official' tarball name (without the _2016.0.109
part), but add the checksum in the easyconfig:
checksums = ['f57a892fb494db3c80f20a88aa3e901f']
If we notice that Intel isn't properly versioning the tarballs with a future release, we can change this easyconfig accordingly and require renaming the downloaded tarball.
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4352/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
@DirkdeDraak: thanks a lot for tackling this! Let me know if something isn't clear w.r.t. the remarks. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4354/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4382/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4383/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4385/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
@boegel I see errors about How to fix/overcome them? |
@DirkdeDraak: the problem is caused because you're fetching the value of |
# license file | ||
import os | ||
license_file = os.path.join(os.getenv('HOME'), "licenses", "intel", "license.lic") | ||
license_file = os.path.join(os.getenv('HPC_BUILDENV_ROOTPATH'), "licenses", "intel", "USE_SERVER.lic") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DirkdeDraak: don't include site-specific things like this in easyconfigs you contribute
In fact, there's no need to modify the easyconfig at all to make sure your easyconfig file is picked up.
If you define $INTEL_LICENSE_FILE
in your environment, the IntelBase
easyblock will pick it up and use it (which gets preference over the license_file
value defined here).
Jenkins: test this please |
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4498/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
checksums = ['f57a892fb494db3c80f20a88aa3e901f'] | ||
|
||
gcc = 'GCC' | ||
gccver = '5.2.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
Test report by @wpoely86 |
@DirkdeDraak: please merge https://github.com/DirkdeDraak/easybuild-easyconfigs/pull/1 to update this, mostly because of the incompatibilities with GCC 5.x (cfr. #2100) |
will be merged via #2209 |
This will get merged/closed automatically when #2209 is merged. No point in doing it manually. |
@wpoely86: I'm aware of that, but it's good to know where it'll will be merged through, and having duplicates open is making me lose track of things |
Added support for installing icc, ifort and toolchain iccifort version 2016.0.109.
edit: requires easybuilders/easybuild-easyblocks#691