RPATH support using ld wrapper (WIP) #1613
Conversation
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2678/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
| descr = ("RPATH options", "changes linking to include rpaths") | ||
|
|
||
| opts = OrderedDict({ | ||
| 'rpath': ("Enable RPATH support", None, 'store_true', False), |
There was a problem hiding this comment.
do you expect other options here?
if not, this shouldn't be an option group by itself?
|
@rjeschmi: this looks pretty basic (good!), but I think wrapper |
|
I'll probably leave it as an "option" I feel like having a wrapper available with some more generic hooks is a good thing and might lead to helpful debugging or special case handling in the future. The way it is injected makes it low risk for inclusion even if it is not the default method Ultimately for some cases this might work better than setting environment variables and is a good option to have around. |
| dir=`pwd` | ||
| for (( i=${#@}; i >= 0; i-- )); do | ||
| if [[ ${!i} == "--enable-new-dtags" ]]; then | ||
| ## we are removing this flag if passed as it creates a copy of rpath to runpath. |
There was a problem hiding this comment.
Aren't we at the mercy of what the default is set to here? We probably should (always) be adding --disable-new-dtags to the arguments as well as removing --enable-new-dtags
|
TODO:
|
|
EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2776/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
I am working to getting this working to spec, but I thought I'd start the PR with a version using the wrapper. It works well enough, but I haven't removed the module deps yet (so LD_LIBRARY_PATH is still populated)