Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THR-27: add language param to h5p endpoints #2734

Merged

Conversation

SteKrause
Copy link
Contributor

@SteKrause SteKrause commented Aug 14, 2023

Short Description

The H5P-Editor needs the language of the user to show the requested editor in the right language.

Links to Ticket and related Pull-Requests

Ticket: https://ticketsystem.dbildungscloud.de/browse/THR-27

PR Server: hpi-schul-cloud/schulcloud-server#4283

Changes

Added language param from i18n to the h5p-editor request/endpoint.

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@SteKrause SteKrause added the WIP someone is working on that label Aug 14, 2023
@SteKrause SteKrause added waiting for review Someone should review this ASAP and removed WIP someone is working on that labels Aug 14, 2023
@SteKrause SteKrause merged commit 2e3588e into THR-18-dev-feature-h5p-editor Aug 15, 2023
@SteKrause SteKrause deleted the THR-27-h5p-language-parameter branch August 15, 2023 11:37
casparneumann-cap added a commit that referenced this pull request Nov 16, 2023
* Thr 12 h5p editor player (#2540)

* Create proxy for h5p editor in dev-environment

* basic implementation h5p page

* id variable and refactoring

* added editor page

* change and add routes

* sonar issues fixed

---------

Co-authored-by: Marvin Rode <marvin.rode@capgemini.com>

* Thr 20 create UI elements (#2577)

* Integrated H5P Webcomponents into Vue client

* add script-src-elem to nginx config

* add H5P_IMG_SRC_URLS to nginx config

* THR-27: add language param to h5p endpoints (#2734)

* add language param to h5p endpoints

* generate client server

* update h5p imports

* THR-6 H5P Editor authorization frontend changes (#2775)

* Generate API and include parent information

* Vue prop types

* add location h5p to csp rules

* copy second index.html for h5p location ins csp rules

* Update Dockerfile

* Update nginx.conf.template

* h5p editor: resolve overseen merge conflict termsofuse

* delete deprecated code from nuxt removal

* h5p editor: csp: remove unsafe inline

* fix prettier problem

* fix duplicate imports

* csp error isolation: set default-src *

* csp error isolation: revert and add unsafe-inline for script-src

* csp error isolation: set script-src *

* csp error isolation: no whitelist used

* csp error isolation: set again default-src *

* csp error isolation: set script-src * + unsafe inline & eval

* csp error isolation: set back to original

* csp error isolation: use hash for multiple choice

* generate API

* csp error isolation: exclude nonce & use unsafe-inline

* disable eslint

* Update API

* resolve review comments

* add es / uk languages

* try nginx.template h5p fix

* revert nginx.conf h5p change

* Comment Out H5P CSP

* Revert "Comment Out H5P CSP"

This reverts commit 1008e2c.

* H5pEditor Tests -> Setup Wrapper

* initial test for verifying component setup

* add test H5pPlayer

* restructure H5pEditor Test

* Create H5PEditor.page Test

* fix routes

* Create Test H5pPlayerPage

* fix tests h5pPlayerPage

---------

Co-authored-by: Majed Mak <132336669+MajedAlaitwniCap@users.noreply.github.com>
Co-authored-by: Marvin Rode <marvin.rode@capgemini.com>
Co-authored-by: Marvin Rode (Cap) <127723478+marode-cap@users.noreply.github.com>
Co-authored-by: Andre Blome <andre-david.blome@capgemini.com>
Co-authored-by: Caspar Neumann <caspar.neumann@capgemini.com>
Co-authored-by: MajedAlaitwniCap <majed.alaitwni@capgemini.com>
Co-authored-by: Cedric Evers <12080057+CeEv@users.noreply.github.com>
Co-authored-by: Caspar Neumann <146704428+casparneumann-cap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Someone should review this ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants