From 0b660ce549f9354d840748c49fb27d558292b592 Mon Sep 17 00:00:00 2001
From: virgilchiriac <17074330+virgilchiriac@users.noreply.github.com>
Date: Mon, 12 Aug 2024 09:22:25 +0200
Subject: [PATCH] BC-7347 - update to node 20 (#3497)

---
 .github/workflows/test.yml | 2 +-
 .nvmrc                     | 2 +-
 Dockerfile                 | 4 ++--
 package-lock.json          | 4 ++--
 package.json               | 6 +++---
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index d82b91cb7e..5d1129a570 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -19,7 +19,7 @@ jobs:
             - name: Setup node
               uses: actions/setup-node@v4
               with:
-                  node-version: '18'
+                  node-version: '20'
 
             - name: setup environment and execute mocha tests
               run: npm ci && npm run build && npm run mocha
diff --git a/.nvmrc b/.nvmrc
index 3c032078a4..209e3ef4b6 100644
--- a/.nvmrc
+++ b/.nvmrc
@@ -1 +1 @@
-18
+20
diff --git a/Dockerfile b/Dockerfile
index d3cd70bc5f..cf5ea5a71f 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,11 +1,11 @@
-FROM docker.io/node:18 as git
+FROM docker.io/node:20 as git
 
 RUN mkdir /app && chown -R node:node /app
 WORKDIR /app
 COPY .git .
 RUN git config --global --add safe.directory /app && echo "{\"sha\": \"$(git rev-parse HEAD)\", \"version\": \"$(git describe --tags --abbrev=0)\", \"commitDate\": \"$(git log -1 --format=%cd --date=format:'%Y-%m-%dT%H:%M:%SZ')\", \"birthdate\": \"$(date +%Y-%m-%dT%H:%M:%SZ)\"}" > /app/version
 
-FROM docker.io/node:18-alpine
+FROM docker.io/node:20-alpine
 
 ENV TZ=Europe/Berlin
 
diff --git a/package-lock.json b/package-lock.json
index 07f82f6caa..14bed781f9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -164,8 +164,8 @@
 				"webpack-stream": "^5.2.1"
 			},
 			"engines": {
-				"node": "18",
-				"npm": ">=9"
+				"node": "20",
+				"npm": ">=10"
 			}
 		},
 		"node_modules/@ampproject/remapping": {
diff --git a/package.json b/package.json
index 7a63210184..65da6a6d97 100644
--- a/package.json
+++ b/package.json
@@ -5,7 +5,7 @@
 		"watch": "nodemon --config nodemon.json",
 		"debug": "nodemon --inspect=9310 --config nodemon.json",
 		"debug:container": "nodemon --inspect=0.0.0.0:9310 --config nodemon.json",
-		"lint": "eslint --ext .json --fix . && eslint ./controllers ./helpers ./test/mocha ./api.js ./app.js ./locales --ext .js --ext .json --fix",		
+		"lint": "eslint --ext .json --fix . && eslint ./controllers ./helpers ./test/mocha ./api.js ./app.js ./locales --ext .js --ext .json --fix",
 		"startd": "echo 'Do you mean 'npm run watch'?'",
 		"mocha": "cross-env NODE_ENV=test mocha test/mocha/ --exit --recursive",
 		"build": "gulp clear && cross-env NODE_OPTIONS=--openssl-legacy-provider gulp",
@@ -13,8 +13,8 @@
 		"coverage": "nyc npm run mocha"
 	},
 	"engines": {
-		"node": "18",
-		"npm": ">=9"
+		"node": "20",
+		"npm": ">=10"
 	},
 	"lint-staged": {
 		"static/images/**/*.{png,jpeg,jpg,gif,svg}": [