Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5749 - Missing pop-up for new release notes #3351

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Nov 21, 2023

Description

After the fetching of new release notes, a pop-up with animated presents notifies users about the presence of new release notes. This pop-up is missing!

Reason is, that currently the createdAt (for determing the newest release) was taken by the most recent merged commit. As for the new repo there are no commits after the initial ones and hence the createdAt value is always the old one and so no new releases are shown. Now the publishedAt date is taken as determing value as this is changed with the new repo everytime a new release is done.

Links to Tickets or other pull requests

BC-5749

Changes

  • determine new release by publishedAt instead of createdAt
grafik

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@MartinSchuhmacher MartinSchuhmacher self-assigned this Nov 21, 2023
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MartinSchuhmacher MartinSchuhmacher merged commit 6ffc364 into main Nov 22, 2023
73 of 75 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-5749-release-popup branch November 22, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants