Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project list in Git Browser broken after latest Squeak Trunk updates #243

Closed
j4yk opened this issue Oct 20, 2019 · 2 comments
Closed

Project list in Git Browser broken after latest Squeak Trunk updates #243

j4yk opened this issue Oct 20, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@j4yk
Copy link
Collaborator

j4yk commented Oct 20, 2019

When I click on another project, the visual selection stays at the top project, even though the other panes of the browser are updated. However, I cannot select the top project anymore because, visually, it still is selected, in contrast to the state of the model. Moving the selection with the up and down keys also does not work.

The list uses index-based access via the variable projectIndex in SquitBrowser.

@marceltaeumel Can you please have a look or delegate to the colleagues who were involved in the latest list morph changes? If I used the API wrong, please suggest a fix.

@marceltaeumel
Copy link
Contributor

Yes, due to a different caching strategy in pluggable lists, faulty (or lazy) models might reveal such effects now.

  • PluggableListMorph >> #verifyContents does not work because your model (i.e., SquitBrowser) is no CodeHolder, which implements #stepIn: etc. for the "smart updating" preference.
  • The model SquitBrowser fails to tell the views about the new selection in #refresh.

grafik

@j4yk
Copy link
Collaborator Author

j4yk commented Nov 2, 2019

So an observer notification was indeed missing and went previously unnoticed due to side effects. Tragic. Thank you for the analysis!

@j4yk j4yk closed this as completed in 2ec77a2 Nov 2, 2019
@j4yk j4yk added this to the release 0.8.0 milestone Nov 2, 2019
@j4yk j4yk mentioned this issue Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants