Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku port fails on 32bit #54

Closed
Begasus opened this issue May 9, 2021 · 5 comments
Closed

Haiku port fails on 32bit #54

Begasus opened this issue May 9, 2021 · 5 comments

Comments

@Begasus
Copy link
Contributor

Begasus commented May 9, 2021

The reported error: chafa-popcnt.c:45:10: error: unknown type name '__int32_t'; did you mean 'u_int32_t'? can be fixed with the next solution, would this be ok to create a PR for?

--- a/chafa/internal/chafa-popcnt.c
+++ b/chafa/internal/chafa-popcnt.c
@@ -23,6 +23,10 @@
 #include "chafa.h"
 #include "internal/chafa-private.h"

+#if defined(__HAIKU__)
+    typedef int32_t __int32_t;
+#endif
+
 gint
 chafa_pop_count_u64_builtin (guint64 v)
 {
@hpjansson
Copy link
Owner

Thanks for reporting this.

I think it would be better to just change the instances of __int32_t to guint32. We already use guint64 in the 64-bit case. PR is welcome!

@Begasus
Copy link
Contributor Author

Begasus commented May 9, 2021

Thanks for looking into this, I'll report back later :)

@Begasus
Copy link
Contributor Author

Begasus commented May 9, 2021

PR created, would be nice if someone on a 32bit system could double-check this? :)

@cdluminate
Copy link
Collaborator

Successfully built in i386 debian chroot. We can merge that PR.

@hpjansson
Copy link
Owner

Thanks a lot for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants