Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matcher issue #1971

Open
2 tasks done
epheien opened this issue Jun 29, 2024 · 5 comments
Open
2 tasks done

matcher issue #1971

epheien opened this issue Jun 29, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@epheien
Copy link

epheien commented Jun 29, 2024

FAQ

  • I have checked the FAQ and it didn't resolve my problem.

Announcement

Minimal reproducible full config

Description

this is a fuzzy matcher bug

Steps to reproduce

    local score, matches = matcher.match('core', 'lua/cmp/core.lua', config.matching)
    print(score)
    print(vim.inspect(matches))

add these code in matcher_spec.lua, and run vusted ./lua/cmp/matcher_spec.lua

Expected behavior

can see a lua table to print

Actual behavior

0
{}
...

Additional context

No response

@epheien epheien added the bug Something isn't working label Jun 29, 2024
@epheien
Copy link
Author

epheien commented Jun 30, 2024

  matching = {
    disallow_partial_fuzzy_matching = false, -- default: true
    disallow_symbol_nonprefix_matching = false, -- default: true
  }

add this option is a temp workaround

@iguanacucumber
Copy link

Hi is this issue still present in my fork of nvim-cmp, magazine.nvim ?

@epheien
Copy link
Author

epheien commented Oct 15, 2024

Hi is this issue still present in my fork of nvim-cmp, magazine.nvim ?

If the matcher code had not been modified, the problem would still exist.

Later on, I will submit a PR and add an option to change the matcher, which can use the same fuzzy matcher as Telescope.

@iguanacucumber
Copy link

iguanacucumber commented Oct 15, 2024

If the matcher code had not been modified, the problem would still exist.

matcher code has been modified quite a bit to fix bugs (#1900 & maybe others) and to add caching (#1980)

@epheien
Copy link
Author

epheien commented Oct 15, 2024

matcher code has been modified quite a bit to fix bugs (#1900 & maybe others) and to add caching (#1980)

When I have time, I will go test it and leave a message on this issue once I have the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants