SDL/Vulkan window resize improvements #11451
Conversation
hrydgard
changed the title
|
What I'd seen before when someone else tried this, was that resizing up consistently worked, but resizing down usually crashed. Gonna requeue Travis. -[Unknown] |
UI/ComboKeyMappingScreen.cpp
Outdated
| @@ -169,7 +169,7 @@ void Combo_keyScreen::onFinish(DialogResult result) { | |||
| g_Config.iCombokey4 = arrayToInt(array); | |||
| break; | |||
| } | |||
| g_Config.Save(); | |||
| g_Config.Save("Combo_keyScreen::onFInish"); | |||
There was a problem hiding this comment.
*onFinish
-[Unknown]
SDL/SDLVulkanGraphicsContext.h
Outdated
| int height = 768; | ||
| // We now get the size from the Vk surface, can safely pass in nonsense. | ||
| int width = -1; | ||
| int height = -1; |
There was a problem hiding this comment.
Can't we just use pixel_xres and pixel_yres (which would've been set before this call)?
-[Unknown]
|
Missed some config saves on Windows. -[Unknown] |
|
I tested it on ANV Intel driver is working window mode resize except the maximize button can't rezize display correct on rendering games.
This is not affected the UI PPSSPP |
|
Moving to 1.8.0, no point in blocking 1.7.0 since we don't do official Linux releases. |
|
I think we should at least merge in 8261e6f and f1dbef0. Not sure if the other resize improvements have made the rest of this work. Although my comment on the latter now: perhaps it makes more sense to show it everywhere now, or at least everywhere but UWP. It does mean we show it on iOS, but we may eventually get Metal/MoltenVK there. I don't think it's that misleading/confusing to show the backend even if it's the only one. -[Unknown] |
hrydgard
force-pushed
the
linux-vulkan-work
branch
from
f0ce3cb to
ebce6d8
Compare
hrydgard
force-pushed
the
linux-vulkan-work
branch
from
ebce6d8 to
58c2400
Compare
|
Rebased on master. Not sure if it's drivers or the improved handling of swapchain size in VulkanContext, but it seems stable enough to be usable now. |
|
Fullscren mode Working fine but in Windows mode the resize screen random size wrong (Only in game not affected by UI).
In spite of that it is completely stable now :) |
Starting to work, but I think there's some sync issue left as it's not completely stable.More stable now, for whatever reason.
Mostly fixes #11014