Correct various light param issues based on tests #11574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, had inverted it. This caused it to improperly clear when masked.
We only need the issue reported once.
Matches hardware tests and improves lighting for Virtua Tennis, see hrydgard#4140.
Just to ensure negative factors are handled too, as they are on hardware.
This is correct per hardware tests, see hrydgard#8403. Note that the PS3 emulator running PSP HD remasters does not correctly handle this, and applies specular for negative diffuse factor.
|
Awesome stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on tests in hrydgard/pspautotests#197. Tried to keep the changes separate.
In general:
This could fix other cases. Unfortunately, doesn't appear to fix #4109 or the Blade Dancer lighting issue.
-[Unknown]