Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Timer Hack" setting. #11666

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Remove "Timer Hack" setting. #11666

merged 2 commits into from
Dec 14, 2018

Conversation

hrydgard
Copy link
Owner

Untested, probably low usage and unclear utility.

@hrydgard hrydgard added this to the v1.8.0 milestone Dec 14, 2018
@unknownbrackets
Copy link
Collaborator

This seems to be missing the removal of the actual bool from Config.h? Also, the Reporting.cpp change is accidentally in #11667.

Personally I'm not a fan of the hack, but I don't know how much it helps on older devices.

-[Unknown]

@hrydgard
Copy link
Owner Author

@Emulatorer, why the thumbsdown? Do you use this setting?

@zminhquanz
Copy link
Contributor

Timer Hack not needed at present . Because GOW game have these tweak to improve more performance and using less CPU usage , and more than that . Audio Stretch option to have develop in 1.8.0

@ghost
Copy link

ghost commented Dec 14, 2018

@hrydgard almost all of my games in ppsspp use this but it seems not needed anymore as I test the latest git so.. removing thumbs down 😅

@hrydgard hrydgard merged commit d7d1a5f into master Dec 14, 2018
@hrydgard hrydgard deleted the remove-timer-hack branch December 14, 2018 17:58
@ghost
Copy link

ghost commented Dec 15, 2018

@zminhquanz The Option to timestretch audio, keeping it smooth(er) when running slowly #8717
will be added in v1.8.0 milestone?

@unknownbrackets unknownbrackets mentioned this pull request Mar 2, 2019
Merged
@tywald tywald mentioned this pull request Apr 21, 2019
Closed
@proganime1200
Copy link

still not fix god of war might try to build my own with timer hack enabled

@hrydgard hrydgard mentioned this pull request Dec 19, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hrydgard @unknownbrackets @zminhquanz @proganime1200