WIP: Vulkan/adreno: Apply workaround for Harvest Moon issue #10421 #11691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
changed the title
|
Yeah, good point @unknownbrackets . Marked it as WIP for now, to think more about, but I believe this can get close to a perfect workaround for this particular bug.. if we do understand it (that is, if we can get it to repro consistently...) |
|
And prevent a crash on Persona 3 (deadlock on Adreno driver ) |
|
This Vulkan code shouldn't be related to the Persona 3 GLES bug - is there even another Vulkan bug in Persona 3 (ref: #11355)? -[Unknown] |
|
@unknownbrackets No . Just OpenGL bug on Adreno driver |
|
Seems to work well on my device, and I can't think of any dangers now. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props to Unknown for the workaround idea.