Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assortment of Ridge Racer bugs #13194

Closed
ghost opened this issue Jul 24, 2020 · 68 comments
Closed

Assortment of Ridge Racer bugs #13194

ghost opened this issue Jul 24, 2020 · 68 comments
Labels
GE emulation Backend-independent GPU issues
Milestone

Comments

@ghost
Copy link

ghost commented Jul 24, 2020

The new update for PPSSPP already came but some bugs in Ridge Racer 1 and 2 are left untouched and isn't even fixed or will never be fixed at all...

Already discovered bugs:

Newly found bugs:

  • Headlights glow effect (When car lights are on, they have a white star shaped effect on normal PSP but not on PPSSPP)
  • Black box on menu (Black boxes appear sometimes when scrolling on the menu)
  • Black lines on menu (Black lines appear on menus, disappears when I set Rendering Resolution to 1x PSP)

Honestly, these bugs will never be fixed and will be forever ignored...

@hrydgard
Copy link
Owner

I don't know where you're getting the "will never be fixed" thing from. In an emulator, generally we fix systems, not games. It might be that a future rewrite of the render target system will fix several of these, there's no "never".

As for the replays, those have already been reported in a separate issue and it's an insanely tricky problem.

I'll leave this open since it contains some "newly found bugs" and not just repeats.

As for the headlights glow, got a screenshot of how it looks and what it should look like? Not familiar with that one (normally you mostly see cars from behind anyway...).

Black boxes I haven't seen in the menus. On what device are you seeing that? Which GPU?

@ghost
Copy link
Author

ghost commented Jul 24, 2020

I am using an NViDiA Quadro K620, a decent Intel CPU, and 32GB of RAM... The fact that I said "will never be fixed" is because that months ago, when I first started reporting RR7 bugs in the RPCS3 Github, one RPCS3 developer is fully toxic to me... I reported the same AV Player bug which happens in Ridge Racer 7 and I gave all my info about the bug but he just Closed the issue and disliked it... Heck, he even added a tag called "Meta: Invalid" to my issues, he didn't even asked "I don't fully understand the bug your experiencing.. please specify it a little bit more.." Instead, he just closed my issues as If he thinks its just garbage... I asked him when will the Sunset Heights Red Bug get fixed (already fixed) but he responded with "where can I get that sh*t you're smoking" as if he is saying I'm mentally ill or just on drugs... I got really triggered and stayed off the RPCS3 Github... Hey man, at least your kind and not toxic like him and you always keep an issue open until it is fixed... If your wondering who was going toxic on me, it was this craphead called "AniLeo"... And also, in #2990 i sent the original replays from the original PSP hardware... Check it out:

Seaside Route 765: https://www.youtube.com/watch?v=kQyHEo4S4wg
Sunset Drive: https://www.youtube.com/watch?v=LsFrQ9JJ9T4
Union Hill District: https://www.youtube.com/watch?v=CgpGzMnA_54
Crismonrock Pass: https://www.youtube.com/watch?v=RURjK13Odgk
Midtown Expressway: https://www.youtube.com/watch?v=_iOCyYokMco
Greenpeak Highlands: https://www.youtube.com/watch?v=kydwDBr9MoA&t

@boy13epic
Copy link

Thats a pretty good list of bugs

@ghost
Copy link

ghost commented Jul 24, 2020

@GrandGTA
What i'm going to say is actually my opinion,and i hope you will understand.Issue here is not guy making emulator,but his surrounding itself,because people act as they see,something like reverse engineering at this point.If they see someone acting like a craphead,they will do it because they like their behaviour.That is issue of him being "pressured",and acting like that will just make him bad reputated,what actually can be his goal at first.People don't realize when they make something that involves people,they shouldn't act like that and they should "grow up",because that is priority and rensposibility in work like that.In fact,always has been like that.I won't name people i don't think are here,but act as BS towards others because you have problems won't really solve anything,and it can be trigger to others.Mental health issues are not joke,him saying something like that is really awful.If you ask me,i would spread this among anyone who wants to do same in the future.

In short:screw morons that don't have sense of rensposibility and kindness,as i reported and was reporting at few developers,and i haven't met anyone that rude with mental complex like that idiot,and everyone deserves to know what BS he pulls because of that.Cheers

@hrydgard
Copy link
Owner

@GrandGTA RPCS3 is a completely different project with different people.

@ghost
Copy link
Author

ghost commented Jul 25, 2020

@ghost Thanks mate... At least you care about cyberbullying.... :)

@hrydgard Yes, I know that RPCS3 is different but they have same issues in Ridge Racer like AV Player Bugs... The difference about the community and people is they just ignore those bugs unlike the community here in PPSSPP, the PPSSPP community here is just calm and kind and is willing to fix bugs... Speaking of bugs, check out the Greenpeak Highlands replay...

The star shaped effect in the headlight is much more noticable:

Headlight Stars

And I also noticed that the screen is much more stretched in the normal PSP hardware:

Original PSP Hardware:
Original PPSSPP Hardware

PPSSPP Hardware:
PPSSPP Hardware

If you're gonna ask me if it probably was the recording device because the picture is stretched but no... When I first tried PPSSPP after my PSP got broken, the first thing I noticed is that I am not comfortable with the screen because my PSP displays the game screen stretched... I checked out a gameplay of Ridge Racer on a normal PSP and I was right... The screen is normally stretched...

The lines im talking about is much more visible in the New Rally-X Minigame:
Mini-Game

The black boxes, im not experiencing them again... It was something i did with the settings and it just disappeared...

@LunaMoo
Copy link
Collaborator

LunaMoo commented Jul 25, 2020

Artifacts related to rendering above x1 res are normal with most 2D surfaces as PSP games were not designed nor tested for running above PSP res. You can sometimes counter it with texture scaling or better texture replacement, but there are opposite cases where at least automatic texture scaling will only make it worse. You can also counter it by forcing nearest texture filtering, but it will make things look bad and off from real thing. Either way it's not something that can be "fixed", so if workarounds doesn't help/aren't acceptable, you will have to run the game with x1 render res or live with the glitches, through it's possible to deal with it differently ie using custom upscaling filter instead of linear filtering.

@ghost
Copy link
Author

ghost commented Jul 27, 2020

I noticed that both Android and PC loads the AV Player differently causing it to desync differently... List out the differences on how both of these platforms load and execute the AV Player CPU Autodrive and you might find the fix for it...

@ghost
Copy link

ghost commented Jul 29, 2020

Right now, some of the people in the RPCS3 Github got influenced with AniLeo's idiotic behavior towards me calling me a retard or a piece of shit.... Honestly, i'm really goddamn pissed at seeing this.... AniLeo is trying to make me look like a bitch and is influencing people that he is a good person and I am the piece of skunk shit... He also called me "expired milk".... I'm going to report him rn...

As i said,guy is moron,and his presence is poisonus to every human being there,no point in fighting against them,when it's clear you're better than them.

These bugs persist on my PC,really good list.I can do investigation to find more.

@CookiePLMonster
Copy link
Contributor

I'll just say one thing and not respond further to avoid cluttering the topic and causing headaches for the PPSSPP team, but IMHO the fact you show up with a "reporting issues which will never be fixed lol" attitude and then immediately proceed to complain about being mistreated elsewhere does not paint a good first impression. If your issue in the RPCS3 repo was kept in a similar "fix this already!" tone as this one is, I am not surprised in the slightest it was met with a negative response.

@ghost
Copy link
Author

ghost commented Jul 30, 2020

Im gonna close this issue... These bugs aren't a big deal anyways since it does not interfere with the gameplay itself... Don't reopen this issue....

@ghost ghost closed this as completed Jul 30, 2020
@hrydgard hrydgard reopened this Jul 30, 2020
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Jul 30, 2020
@hrydgard hrydgard added this to the Future milestone Jul 30, 2020
@hrydgard hrydgard changed the title List of Ridge Racer bugs that are left unfixed or will never be fixed + newly found bugs... Assortment of Ridge Racer bugs Jul 30, 2020
@ghost
Copy link
Author

ghost commented Aug 1, 2020

I deem the AV Player SR765 Replay impossible for me to replicate... Used a CE speedhack, the Angelus always throws me off by overtaking or not taking a specific lane...

@gamer-gamer
Copy link

Maybe an option not to upscale 2d like Gliden64 for n64 emulator does might correct some of those 2d issues ? Unless that isnt possible.

@ghost
Copy link
Author

ghost commented Oct 10, 2020

Also found out that since Android and PC have different ways of desyncing because of different CPU numbers and calculations, try and list every and I mean every single CPU differences on both Android and PC version of PPSSPP... Its like Android is 1.0 and PC is 2.0 and to stop it from desyncing, it needs to be in 1.5...

@Back2Life888
Copy link

Hey guys, I have a better image than GrandGTA. I found a Ridge Racer PSP video with a good recording device and resolution of 720p.. This is what it looks like with much better quality.

Sparkol

@Back2Life888
Copy link

Im also planning on getting a new PSP to contribute to these bugs..

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

I think i found a workaround... I just need to confirm it now.

Ok. This is confirmed now.

Setting 'Internal Resolution' to anything other than 1x will break the headlights. It also requires 'OpenGL' backend/video driver

1x Internal Resolution. Texture Scaling: 0

1x Internal Resolution Texture Scaling: 3 Video Filter: hq3x

@hrydgard
Copy link
Owner

That is interesting! Might help figuring out what's going wrong here.

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

I've also found they headlights will shine anytime they are supposed to thru the regular viewport (main game cam) with 1x resolution.

Not sure if they are supposed to appear in rearview mirror. But if i drift particularly enthusiastically thru a tunnel. The opponents headlights are shining

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

Possibly related.

I've been testing [ReinterpretFramebuffers] & [ShaderColorBitmask] with this title UCES00422

And thus far I've noticed no adverse effects.

@hrydgard
Copy link
Owner

Have you noted any positive effects of those, though?

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

No, Reflections may be improved. I'll have to compare some streams side by side (twitch.tv/Veritas0923)

I also noticed one more thing. A white-ish box around the tach with Assoluto

I've been trying all manner of settings to fix headlights, digital tachs and that white box specifically.

I believe that was before I discovered the 1x thing thou. I will test these settings again.

@Back2Life888
Copy link

I think i found a workaround... I just need to confirm it now.

Ok. This is confirmed now.

Setting 'Internal Resolution' to anything other than 1x will break the headlights.

1x Internal Resolution. Texture Scaling: 0

1x Internal Resolution Texture Scaling: 3 Video Filter: hq3x

hold on.. How in the hell did you manage to load up the headlight glare effect even if PPSSPP doesn't load it??

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

By using the settings specified. Any setting for 'Internal Resolution' other than 1x (the first one) will break the headlight glare. Scale by other means (hq2x/hq3x video shader or example) the headlight glare remains.

@Back2Life888
Copy link

Where can I find the hq2x or hq3x video shader?? And by Internal Resolution, you mean Rendering Resolution??

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

lol no, C:\EMU\RetroArch\ & C:\EMU\PSP\

@Back2Life888
Copy link

Well in conclusion.. Your specs may be s**t af while my specs are better than yours but somehow, your specs brings back one of the most nostalgic effect on the game..

@Back2Life888
Copy link

I guess I give up on this one..

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

It's not the size of your GHz that counts ... It's how you use it...

@Back2Life888
Copy link

but still.. You managed to make it work.. I give up since it probably wouldn't work..

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

Enthusiastically drifting thru a tunnel during a race... Headlights observed.

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

Reflections seem unaffected to me..

ReinterpretFramebuffers & ShaderColorBitmask On

ReinterpretFramebuffers & ShaderColorBitmask Off

@hrydgard
Copy link
Owner

However the game is doing the headlights, it's doing something very delicate or sensitive, it seems, since it breaks so easily. Can be tiny differences between how different GPUs render. Need to figure out how it's actually working to fix it properly...

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

The 1x resolution & OpenGL seem key to making it work thru the regular game race/countdown/replay. Trying to make it work in rearview now...

Basically trying every setting in compat.ini w\ 1x res now. (Except the 'warn' ones)

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

This is the rearview itself being drawn

I think this, may be a relevant frame. Stepping thru the textures this is the first time the headlights appear in rearview.

The next texture to be loaded there is the rims i think. Then this happens. Entire screen gets copied here. Then UI elements are drawn.

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

Screen being copied

HUD elements about to be drawn

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

Here's a savestate of me paused at that same frame.

PPSSPP_STATE.zip

@VTSTech
Copy link

VTSTech commented Feb 16, 2021

Before i was stepping by frame. Stepping into each instruction while it builds the frame ... This is where it draws the actual headlight

(This is during a race, facing reverse, paused, looking at opponent)

That part is applied before. Then whatever this is

Then a similar process repeats for the actual headlight

@hrydgard
Copy link
Owner

Hm, it's somehow texturing from a 1x1 texture (which happens to share address with a bigger one, which is why what you see there is not 1x1). Maybe that's supposed to be a certain value from the framebuffer at the pixel location of the headlight, so that if it gets overdrawn with something, it won't have that value and the headlight won't be drawn. or something...

@unknownbrackets
Copy link
Collaborator

This games does other rendering to a palette, might be related to this 1x1 business. Maybe we don't clamp to 1x1 properly, esp with aniso or etc.? Though we should clamp with offset and size settings, we've mostly focused on clamping when size is larger than actual FB size...

-[Unknown]

@VTSTech
Copy link

VTSTech commented Feb 17, 2021

Back2Life do you use a nVidia GPU by chance ?

As I've shown, It worked for me just fine in standalone PPSSPP.

But. I was using 1x Res, OpenGL and i use an AMD GPU. It isn't all that rare to have rendering differences/issues between nVidia/AMD. I recall a similiar rendering issue on PS3 emulation with RR7, nVidia couldn't do trees right for the life of it. But it 'just worked' on AMD.

I've always found AMD wins these battles thou, So that's why I use an AMD GPU

@hrydgard
Copy link
Owner

Not much point in speculation, this just needs to be investigated properly.

@VTSTech
Copy link

VTSTech commented Feb 17, 2021

Feel free to send me (or just branch) a test build if you would like me to test anything with my setup :) I'm not very good with GFX or real time debugging. But I can test. And compile. Occasionally I can do meaningful patches from disassembly

@Back2Life888
Copy link

Yeah I am using an NVIDIA GPU..

@VTSTech
Copy link

VTSTech commented Feb 22, 2021

Happened to be playing the original RR for PSP and can confirm the Headlights 1x Internal Res + OpenGL workaround also works there.

@Back2Life888
Copy link

any updates?

@Back2Life888
Copy link

i can confirm that the headlight glare only works on AMD cards. I managed to find a laptop with a AMD card on it and boom, the headlight glare was present.

@Back2Life888
Copy link

Sadly, the speedometer is still in the same state in AMD cards

@ghost
Copy link

ghost commented Jan 11, 2022

@unknownbrackets Do you know about the textures getting corrupted in the software render? The tracks look normal then after maybe a lap or two the texture colors start to get weird. I've heard the game does some weird memory stuff before starting a track though which I'm guessing the HLE render doesn't even touch. Also Cosmo canyon in ridge racer 2 is causing a crash that takes out the entire emulator in the WIP x64 windows build.

Edit: I mean diablo canyon road, no idea where I got cosmo canyon from

@Back2Life888
Copy link

Back2Life888 commented Jan 12, 2022

@unknownbrackets Do you know about the textures getting corrupted in the software render? The tracks look normal then after maybe a lap or two the texture colors start to get weird. I've heard the game does some weird memory stuff before starting a track though which I'm guessing the HLE render doesn't even touch. Also Cosmo canyon in ridge racer 2 is causing a crash that takes out the entire emulator in the WIP x64 windows build.

Probably a corrupted game copy.

Edit: Disregard this line. Apparently some artifacts can be seen in software rendering.

@Back2Life888
Copy link

Back2Life888 commented Mar 31, 2022

So in summary (04-01-22)

-Still has broken replays (If anyone has a normal PSP hardware, record the undesynced replays and send me the video. The links given above are from a terminated account.)
-Speedometers without needles are broken (Workaround is software rendering but its super slow)
-Semi-broken headlight glare (Headlight glare works on NViDiA now! Only problem is though is that it renders at a small distance and only right headlights works. Headlight glare still works like a charm in AMD.)
-Screen ghosting effect when using NOS (sometimes occur)

There is progress, but it might take months to fix these. Maybe even years.

@hrydgard
Copy link
Owner

I believe these are all fixed:

  • Speedometers
  • Lens flare / headlight glare / whatever you call it
  • Ghosting bug when using Nitro

Remaining are replays and FMV issues, plus general issues with texture tiling in the menus, which is not specific to Ridge Racer, just something that happens when you render a game at a higher resolution than what it was designed for.

We have separate issues for the remaining problems, not setting much point in this meta-issue anymore so I'll close it.

@unknownbrackets unknownbrackets modified the milestones: Future, v1.14.0 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

8 participants