Cleanup line/point handling and refactor a bit #15073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These already always go through software transform, so make sure we handle them consistently. We'll eventually convert to triangles.
Just so it's cleaner when the same is done for lines.
|
Yeah, really nice to get this in as a separate step before more major stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are actually just some rebased commits I had from some previous lines/points-as-triangles work.
We're already pushing lines and points through software transform (just like rectangles), so these are actually cleanup anyway.
This shouldn't really change anything yet, just makes it a bit easier to move lines and points to triangles.
-[Unknown]