Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI Tint/Saturation settings #15396

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Add UI Tint/Saturation settings #15396

merged 4 commits into from
Feb 18, 2022

Conversation

hrydgard
Copy link
Owner

Does the color tinting in the vertex shader.

Makes the background grayscale, and sets a color, so it'll follow the tint properly.

Lighter alternative to full custom themes as in #15394, although I'm kinda torn which way to go.

iota97 started work on the same too at my suggestion. This uses a simpler hsv conversion, not sure which one looks best though. Adds support for all the backends too.

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Feb 11, 2022
@iota97
Copy link
Contributor

iota97 commented Feb 11, 2022

Just a few thing to improve the UI:

  • Remove darkening background (kinda off with live update)
  • Allow to increase saturation as well

Pushed it here: https://github.com/iota97/ppsspp/tree/vertex-hue-ui

Time to make a RGB animation now ;)

@hrydgard
Copy link
Owner Author

Pulled your change, nice, makes sense.

@hrydgard
Copy link
Owner Author

Still a bug left with uniform bufer sizes, fixing.

@iota97
Copy link
Contributor

iota97 commented Feb 11, 2022

Pushed at the same branch as before a fix for the live update that wasn't quite complete :P

@hrydgard hrydgard marked this pull request as ready for review February 12, 2022 10:21
@hrydgard
Copy link
Owner Author

Thanks, picked it over.

@ghost
Copy link

ghost commented Feb 18, 2022

how about this now?

@hrydgard hrydgard enabled auto-merge February 18, 2022 13:27
@hrydgard hrydgard disabled auto-merge February 18, 2022 13:27
@hrydgard hrydgard merged commit 86681f0 into master Feb 18, 2022
@hrydgard hrydgard deleted the ui-tint-saturate branch February 18, 2022 14:13
@hrydgard
Copy link
Owner Author

Confirmed that this does indeed work just fine on Mali-400.

@unknownbrackets unknownbrackets added this to the v1.13.0 milestone Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants