Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libretro jni builid failed #16313

Closed
6 tasks done
hsoftxl opened this issue Nov 1, 2022 · 1 comment · Fixed by #16314
Closed
6 tasks done

libretro jni builid failed #16313

hsoftxl opened this issue Nov 1, 2022 · 1 comment · Fixed by #16314
Labels
Libretro Issue on Libretro but not all ports.
Milestone

Comments

@hsoftxl
Copy link
Contributor

hsoftxl commented Nov 1, 2022

Platform

libretro / Retroarch

Compiler and build tool versions

ndk 21e

Operating system version

ubuntu 20.04

Build commands used

$NDK/ndk-build

What happens

[armeabi-v7a] Compile++ thumb: retro <= ControlMapper.cpp
[armeabi-v7a] Compile++ thumb: retro <= TextureReplacer.cpp
/home/xielei/ppsspp/libretro/jni/../../Core/TextureReplacer.cpp:645:19: error: no matching function for call to 'zip_fread'
pngdata.resize(zip_fread(zf, pngdata.data(), pngdata.size()));
^~~~~~~~~
../../ext/libzip/zip.h:409:24: note: candidate function not viable: no known conversion from 'const std::__ndk1::basic_string<char, std::__ndk1::char_traits, std::__ndk1::allocator >::value_type *' (aka 'const char *') to 'void *' for 2nd argument
ZIP_EXTERN zip_int64_t zip_fread(zip_file_t *_Nonnull, void *_Nonnull, zip_uint64_t);
^
/home/xielei/ppsspp/libretro/jni/../../Core/TextureReplacer.cpp:1171:20: error: no matching function for call to 'zip_fread'
pngdata.resize(zip_fread(zf, pngdata.data(), pngdata.size()));
^~~~~~~~~
../../ext/libzip/zip.h:409:24: note: candidate function not viable: no known conversion from 'const std::__ndk1::basic_string<char, std::ndk1::char_traits, std::ndk1::allocator >::value_type *' (aka 'const char *') to 'void *' for 2nd argument
ZIP_EXTERN zip_int64_t zip_fread(zip_file_t *_Nonnull, void *_Nonnull, zip_uint64_t);
^
2 errors generated.
make: *** [/home/xielei/ndk/android-ndk-r21e/build/core/build-binary.mk:478: /home/xielei/ppsspp/libretro/obj/local/armeabi-v7a/objs/retro//
/Core/TextureReplacer.o] Error 1

PPSSPP version affected

commit e97d549

Last working version

No response

Checklist

  • Test in the latest git build in case it's already fixed.
  • Make sure to run git submodule update --init --recursive before building.
  • Search for other reports of the same issue.
  • Try deleting the build directory and running the build again.
  • Check GitHub Actions, which builds every merge and PR.
  • Include logs and help us reproduce.
@unknownbrackets
Copy link
Collaborator

Well, I guess libretro is still using c++14 or c++11, and so doesn't have .data() as char *.

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.14.0 milestone Nov 1, 2022
@unknownbrackets unknownbrackets added the Libretro Issue on Libretro but not all ports. label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libretro Issue on Libretro but not all ports.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants