Display layout editor - Remove editing widget, just use the background directly #16415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We lose the snapping in the refactor because I ended up rewriting the whole dragging mechanism, might reintroduce later.
hrydgard
force-pushed
the
display-edit-mode-2
branch
from
1f6dba9 to
57864f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The display layout editor needed updating, it's probably one of the least intuitive parts of the current UI.
This removes the previous editing widget, and just lets you drag the background around directly.
You can now also access it from the pause screen directly.
The layout and wording is otherwise unchanged, but will be changed later and also include a way to change the post-processing settings and thus directly see a preview. Also I plan to change the settings to be more intuitive and add direct aspect ratio control.
In the case of skip-buffer or not in-game, we just draw a gray rectangle for now.