Crash: Ensure we never handle faults in faults #16636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory, this shouldn't happen because it won't be in jit space, but better to be sure.
We only care about the first one in these places anyway. Also make sure we don't try to match an invalid block number.
unknownbrackets
force-pushed
the
exception-safety
branch
from
a53fd26 to
b9fe48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bit of paranoia. Makes me wish for the simple syntax D had,
scope(exit) { inCrashHandler = false; }.Also tweaked the DescribeCodePtr lookup in case something was going wrong in it. Maybe it returned 0 and a bunch of invalid blocks matched it, or something.
-[Unknown]