Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU: Allow depth above 65535 #16880

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

unknownbrackets
Copy link
Collaborator

Hopefully it rounds down for any == or <= tests.

This helps #16866 at least. Note that it's obviously unsafe when DepthSliceFactor() is 1.0 (i.e. when 65535.0 is mapped to 1.0 in the depth buffer), since that would just mean a draw with Z=1234 and maxz=0xFF00 and then another draw with Z=1234 and maxz=0xFFFF would not match, i.e. >= might fail. That can happen when shadows are being drawn, etc.

-[Unknown]

Hopefully it rounds down for any == or <= tests.
@hrydgard
Copy link
Owner

hrydgard commented Feb 1, 2023

Looks right, let's try it.

@hrydgard hrydgard merged commit 091f9dc into hrydgard:master Feb 1, 2023
@unknownbrackets unknownbrackets deleted the buffer-allowed-z branch February 1, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants