Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for integer scale factor for display #17224

Merged
merged 3 commits into from
Apr 2, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Apr 2, 2023

This is mainly useful if you want an authentic pixellated look with 1x rendering (or software) and nearest display filter. Cave Story is a good game for testing.

The new option is a boolean, that'll simply round down the auto-scaled sized to the nearest integer scale factor, configuring exactly which one isn't that interesting since they all are gonna look good.

Fixes #17093

I'm not a huge fan of the name "Integer scale factor" but I don't really know what would be better, suggestions wanted.

(Oops, just realized that vertical screen rotation isn't gonna look good right now, will fix).

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Apr 2, 2023
@hrydgard hrydgard added this to the v1.15.0 milestone Apr 2, 2023
@unknownbrackets
Copy link
Collaborator

Maybe "Snap scale to PSP pixels"? Or "Snap to round scale" / "Snap to whole scale"? Not sure. I don't think "Integer scale factor" is bad, really. Integer sounds like a scary math term to some, though.

-[Unknown]

@hrydgard
Copy link
Owner Author

hrydgard commented Apr 2, 2023

Yeah.. none of those really beat Integer scale factor by enough of a margin, and it's called that in some other emulators too. So I think I'll end up sticking with it.

hrydgard added 3 commits April 2, 2023 22:29
This is mainly useful if you want an authentic pixellated look with 1x
rendering (or software) and nearest display filter. It'll simply round
down the auto-scaled sized to the nearest integer scale factor,
configuring exactly which one isn't that interesting since they all are
gonna look good.

Fixes #17093
@hrydgard
Copy link
Owner Author

hrydgard commented Apr 2, 2023

Alright, ready for review.

@unknownbrackets unknownbrackets merged commit ecfd475 into master Apr 2, 2023
@unknownbrackets unknownbrackets deleted the integer-scaling branch April 2, 2023 20:53
@RokkumanX
Copy link

Thank you very much for this, it looks really good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integer scaling option
3 participants