Bump the index/vertex cpu-side buffer sizes a little. #17394
Conversation
GPU/Common/DrawEngineCommon.h
Outdated
| // int maxVerts = DECODED_VERTEX_BUFFER_SIZE / 2 / vertexSize; =~ 54000 | ||
| // 65536 * 6 * 2 |
There was a problem hiding this comment.
I think we could delete this part, I think it's just for the old values.
-[Unknown]
| DECODED_VERTEX_BUFFER_SIZE = VERTEX_BUFFER_MAX * 64, | ||
| DECODED_INDEX_BUFFER_SIZE = VERTEX_BUFFER_MAX * 16, | ||
| DECODED_VERTEX_BUFFER_SIZE = VERTEX_BUFFER_MAX * 2 * 36, // 36 == sizeof(SimpleVertex) | ||
| DECODED_INDEX_BUFFER_SIZE = VERTEX_BUFFER_MAX * 6 * 6 * 2, // * 6 for spline tessellation, then * 6 again for converting into points/lines, and * 2 for 2 bytes per index |
There was a problem hiding this comment.
So 4.5MB each, from previously 4MB + 1MB. I think it's worth the increase in memory of 4MB more. Most will hopefully not be committed anyway.
-[Unknown]
There was a problem hiding this comment.
I'm realizing also that the index buffer here is likely now oversized because if we tessellate splines to the extreme and then convert to lines, we'll run out of vertex space first. Though this didn't happen in the crash.. Oh well. I think we can spare the memory, and then be more systematic about it like a better version of the other change in the next version.
|
Going with this one and bumping the other to 1.16. |
Replaces #17387
May help fix one of the crashes in #17364