Fix a bunch of cases where we forgot to check for CHD files #18924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anr2me
reviewed
Mar 12, 2024
UWP/PPSSPP_UWPMain.cpp
Outdated
| @@ -502,7 +502,7 @@ bool System_MakeRequest(SystemRequestType type, int requestId, const std::string | |||
| std::vector<std::string> supportedExtensions = {}; | |||
| switch ((BrowseFileType)param3) { | |||
| case BrowseFileType::BOOTABLE: | |||
| supportedExtensions = { ".cso", ".bin", ".iso", ".elf", ".pbp", ".zip" }; | |||
| supportedExtensions = { ".chd", ".cso", ".bin", ".iso", ".elf", ".pbp", ".zip" }; | |||
There was a problem hiding this comment.
just wondering why .prx extension can't be found in this list :) since prx files can be run on PPSSPP too (ie. sample files from PSPSDK)
There was a problem hiding this comment.
was probably just forgotten when the list was created. I'll add it.
hrydgard
force-pushed
the
chd-detection-fixes
branch
from
3ff299c to
55974f6
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix some issues like possibly #18919 .