Fix render-to-texture: Midnight Club L.A. Remix

[dbz400]

Responsible line :

    // Ensure it's in the framebuffer cache.
    if (std::find(fbCache_.begin(), fbCache_.end(), framebuffer) == fbCache_.end()) {
        fbCache_.push_back(framebuffer);
    }

Correct one should be

[unknownbrackets]

Well, that's basically disabling the hookup (which is in SetTexture().) But I think this will break Brave Story and Mana Khemia (may have to double check later.)

Is the framebuffer it grabs not being rendered to?

-[Unknown]

[papel]

The buildings are not good yet. The image on PSP should be:

[dbz400]

How i can check the framebuffer it grabs not being rendered to in this case ?

[unknownbrackets]

Here's where it grabs it:

    // If we ended up with a framebuffer, attach it - no texture decoding needed.
    if (entry->framebuffer) {
        SetTextureFramebuffer(entry);
        lastBoundTexture = -1;
        entry->lastFrame = gpuStats.numFlips;
        return;
    }

But maybe the most relevant way would be to stop keeping it alive:

            // Keep the framebuffer alive.
            // TODO: Dangerous if it sets a new one?
            entry->framebuffer->last_frame_used = gpuStats.numFlips;

Comment that out, and it'll decimate the framebuffer at some point if it's not being rendered to.

-[Unknown]

[dbz400]

I did try to comment out that one keep the frambuffer alive but it didn't help

[dbz400]

I just checked Brave story still seems to be fine with this change.

[dbz400]

@unknownbrackets , just wonder if comment this out , does it break Mana Khemia ?

[unknownbrackets]

Yes. Here's a screenshot:

-[Unknown]

[unknownbrackets]

To clarify, this is what it seemed to be doing from looking at the renders:

1. Render normal game screen to framebuffer A (the part it's gonna blur for this effect in dialog.)
2. Use render-to-texture to render this to framebuffer B.
3. From now on, use render-to-texture from framebuffer B to draw to screen on framebuffer C.

Basically, you have a once in a lifetime chance of getting the correct framebuffer at step 1. It never uses A again. Once it draws B, it assumes B is good. So we can't just be lazy and get it wrong the first time and rely on the game redrawing it over and over to make it right.

-[Unknown]

[dbz400]

I see. Render-to-texture is really tricky and difficult to handle it correctly .

For the fbCahce_ change , it is a significant improvement for Mana Khemia

[unknownbrackets]

Yeah.. very tricky.

To be fair, the blurred part is only during dialog, and it doesn't move (e.g. the dialog goes away and it unblurs when people walk around.) The game at least from what I've played seems fine otherwise. But it's pretty jarring.

-[Unknown]

[dbz400]

Just checked softgpu for this Midnight L.A. Mix and seems to be rendered close to real PSP

[dbz400]

Just few more testing on GLES, it is stencil issue and disable part of the stencil ops and looks far better

[arcade1977]

Oh, it looks good ! it is better than 0.8.1.1678

[arcade1977]

But there are a lot of black block in the background?

[dbz400]

Yes , it is becasue the stencil test is still incorrect .It should hide those trees

[dbz400]

Few more attempt to try and get a correct one though it is a combination trial of ZFail/ZPass .

Try compare with the above pic from real PSP.

[arcade1977]

This picture looks almost with real PSP ,good job!

[dbz400]

This is my testing combination of zfail/zpass

        if (gstate.isDepthWriteEnabled()) {
            zfail = GL_KEEP;
            zpass = GL_KEEP;
        } else { 
            zfail = GL_ALWAYS;
            zpass = GL_ALWAYS;
        }
        glstate.stencilOp.set(stencilOps[gstate.getStencilOpSFail()],  // stencil fail
            zfail,  // depth fail
            zpass); // depth pass

[dbz400]

This has been fixed by latest build .Closed