Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt Graphical issues #3710

Closed
Vality opened this issue Sep 9, 2013 · 3 comments
Closed

Qt Graphical issues #3710

Vality opened this issue Sep 9, 2013 · 3 comments

Comments

@Vality
Copy link
Contributor

Vality commented Sep 9, 2013

This may be user error on my part but the interface to the Qt build seems oddly broken. Various buttons are cut off or only partly responsive and graphics are cut off or missing.
Note this effects only the menu and actual game-play and emulation are flawless.

I have tried various layouts for adding the resources, images and such other files, putting them in /usr/share, putting them with the binary itself, putting them in both assets and resources subdirectories with the binary but none of this helped.

The main menu appears as below and the settings menu has similar issues.

No output out of the ordinary was displayed on the terminal which I ran ppsspp from so that gave me no clues of the issue, nor were there any debug logs.

I am sorry if this is my own misconfiguration but any help would be most appreciated.

Its worth noting the SDL version runs fine with no issues.

resultsgui1
resultsgui2
resultsgui3

@hrydgard
Copy link
Owner

hrydgard commented Sep 9, 2013

Looks like problems with the scissor rectangle (see pushscissor/popscissor in native/ui/ui_context.cpp ). I think you must be passing in the wrong window dimensions when computing dp_xres/yres or one of the scale factors.

@Vality
Copy link
Contributor Author

Vality commented Sep 9, 2013

@hrydgard
I have found a fix for this issue.

The Calculate DPI Scale function is causing the scissor rectangles to scale but not the actual menus and graphics.

A temporary workaround to prevent the broken ui is to simply set the scale factor to 1:

--- native/base/QtMain.cpp      2013-09-09 22:33:58.233730706 +0100
+++ native/base/QtMain.cpp.patched      2013-09-09 22:34:09.697730236 +0100
@@ -69,7 +69,7 @@
 #ifdef __SYMBIAN32__
        return 1.4f;
 #else
-       return 1.2f;
+       return 1.0f;
 #endif
 }

Ultimately it would be better to fix the issue, which I am looking into at the moment, but this would be a good idea to temporarily unbreak the build.

Edit:
On second thought, the dpi scaling seems fairly pointless on QT anyway given the scaling is just guessed and there is no reliable way to find its true value (most graphics drivers do not give that information).

In addition the interface is not all that scalable anyway at least in QT, I would consider disabling the feature in QT for now at least until it can be implemented properly and fixed.

@hrydgard
Copy link
Owner

hrydgard commented Sep 9, 2013

Just force it to 1 with an ifdef.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants