Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include screenshots in compatibility reports #8812

Merged
merged 8 commits into from
Jun 12, 2016

Conversation

unknownbrackets
Copy link
Collaborator

The main high level things this does:

  • Adds a way to cap screenshot dimensions at high resolutions, no UI.
  • Allows optional screenshots (max 1920x1088) and icon upload to the server.
  • Enables mipmaps for savestate screenshots in more places.
  • Shows the Feedback button even when reporting is disabled, and prompts to enable.

The reason reporting is required is that reports (especially negative ones) without error information aren't very useful. We could disconnect it, with some changes.

Note: currently the server is storing but not serving these images. For security reasons, we'll need to validate the uploaded images before serving, but at least they aren't going into a blackhole

-[Unknown]

@hrydgard hrydgard merged commit b0ac553 into hrydgard:master Jun 12, 2016
@unknownbrackets unknownbrackets deleted the reporting branch June 12, 2016 19:05
@unknownbrackets
Copy link
Collaborator Author

Whoops, looks like I generated an ICE on some gcc versions. I'll just remove, wanted to be explicit that it was zeroed...

-[Unknown]

@unknownbrackets unknownbrackets mentioned this pull request Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants