Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix loading ends up with a blank/white screen #466

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

hrzlgnm
Copy link
Owner

@hrzlgnm hrzlgnm commented Oct 27, 2024

  • Handle errors when listening on events
  • Use create_memo for expensive validity checks
  • Set focus to input after 3s
  • Use untracked signals where it does not matter
  • Dev tools and no splash screen in debug mode
  • Emit metrics only when changed but check every second
  • Revert fix: Workaound window sometimes only showing a white background #459 as it was not fixing anything

@github-actions github-actions bot added the bug Something isn't working label Oct 27, 2024
@hrzlgnm hrzlgnm changed the title bugfix: WiP: Sometimes loading ends up with a blank/white screen fix: WiP: Sometimes loading ends up with a blank/white screen Oct 27, 2024
@hrzlgnm hrzlgnm force-pushed the fix/loading-fixes branch 4 times, most recently from c47c55f to 66347e8 Compare October 29, 2024 21:00
- Handle errors when listening on events
- Use create_memo for `expensive` validity checks
- Set focus to input after 3s
- Use untracked signals where it does not matter
- Dev tools and no splash screen in debug mode
- Emit metrics only when changed but check every second
@hrzlgnm hrzlgnm marked this pull request as ready for review October 29, 2024 21:11
@hrzlgnm hrzlgnm changed the title fix: WiP: Sometimes loading ends up with a blank/white screen fix: attempt to fix loading ends up with a blank/white screen Oct 29, 2024
@hrzlgnm hrzlgnm enabled auto-merge (squash) October 29, 2024 21:12
@hrzlgnm hrzlgnm merged commit dddf8bc into main Oct 29, 2024
5 checks passed
@hrzlgnm hrzlgnm deleted the fix/loading-fixes branch October 29, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant