From fa03d5e50df7748330c3d88a63170c01e6e15007 Mon Sep 17 00:00:00 2001 From: Wendell Date: Sun, 24 Feb 2019 12:55:35 +0800 Subject: [PATCH] build: add noUnusedParameters config (#2960) * build: add noUnusedLocals config * build: add noUnusedParameters config --- components/affix/affix.spec.ts | 4 +- components/anchor/anchor.spec.ts | 6 +-- .../auto-complete/demo/uncertain-category.ts | 2 +- components/back-top/back-top.spec.ts | 10 ++--- components/button/nz-button.spec.ts | 2 +- .../cascader/demo/change-on-function.ts | 2 +- .../cascader/demo/custom-field-names.ts | 2 +- components/cascader/demo/modal.ts | 2 +- .../cascader/nz-cascader.component.html | 4 +- components/cascader/nz-cascader.component.ts | 12 ++--- components/cascader/nz-cascader.spec.ts | 4 +- .../checkbox/nz-checkbox-group.component.ts | 2 +- components/core/util/logger/logger.service.ts | 22 +++++----- .../date-picker/date-picker.component.spec.ts | 7 ++- components/date-picker/demo/disabled-date.ts | 2 +- .../lib/decade/decade-panel.component.ts | 2 +- .../lib/month/month-table.component.ts | 2 +- components/date-picker/lib/util.spec.ts | 4 +- .../lib/year/year-panel.component.ts | 2 +- .../month-picker.component.spec.ts | 6 +-- .../range-picker.component.spec.ts | 6 +-- .../date-picker/year-picker.component.spec.ts | 6 +-- components/grid/nz-col.directive.ts | 9 ++-- components/icon/page/index.ts | 4 +- components/list/demo/vertical.ts | 2 +- .../pagination/nz-pagination.component.ts | 2 +- .../select/nz-option-container.component.ts | 4 +- .../select/nz-select-top-control.component.ts | 2 +- components/skeleton/demo/list.ts | 2 +- components/slider/nz-slider-step.component.ts | 2 +- components/slider/nz-slider.component.ts | 2 +- components/tag/nz-tag.component.ts | 3 +- components/transfer/transfer.spec.ts | 6 +-- .../tree-select/nz-tree-select.component.ts | 1 + components/tree/demo/directory.ts | 2 +- components/tree/nz-tree-node.component.ts | 3 +- components/tree/nz-tree.spec.ts | 18 ++++---- components/upload/demo/custom-request.ts | 4 +- components/upload/demo/manually.ts | 4 +- components/upload/upload.spec.ts | 44 +++++++++---------- .../share/nz-codebox/nz-codebox.component.ts | 2 +- tsconfig.json | 1 + 42 files changed, 109 insertions(+), 119 deletions(-) diff --git a/components/affix/affix.spec.ts b/components/affix/affix.spec.ts index 589ad466774..c9ebe049f88 100644 --- a/components/affix/affix.spec.ts +++ b/components/affix/affix.spec.ts @@ -346,7 +346,7 @@ describe('affix', () => { }); }); - it(`emit true when is affixed`, fakeAsync((done) => { + it(`emit true when is affixed`, fakeAsync(() => { setupInitialState(); emitScroll(window, defaultOffsetTop + startOffset + 1); @@ -355,7 +355,7 @@ describe('affix', () => { discardPeriodicTasks(); })); - it(`emit false when is unaffixed`, fakeAsync((done) => { + it(`emit false when is unaffixed`, fakeAsync(() => { setupInitialState(); emitScroll(window, defaultOffsetTop + startOffset + 1); emitScroll(window, defaultOffsetTop + startOffset - 1); diff --git a/components/anchor/anchor.spec.ts b/components/anchor/anchor.spec.ts index 067b26d934a..07b6732496b 100644 --- a/components/anchor/anchor.spec.ts +++ b/components/anchor/anchor.spec.ts @@ -31,9 +31,9 @@ describe('anchor', () => { describe('[default]', () => { it(`should scolling to target via click a link`, () => { spyOn(srv, 'scrollTo').and.callFake(( - containerEl: Element | Window, - targetTopValue: number = 0, - easing?: any, + _containerEl: Element | Window, + _targetTopValue: number = 0, + _easing?: any, callback?: () => void ) => { callback(); diff --git a/components/auto-complete/demo/uncertain-category.ts b/components/auto-complete/demo/uncertain-category.ts index 33b83cef9a4..c111ed3c792 100644 --- a/components/auto-complete/demo/uncertain-category.ts +++ b/components/auto-complete/demo/uncertain-category.ts @@ -38,7 +38,7 @@ export class NzDemoAutoCompleteUncertainCategoryComponent { onChange(value: string): void { this.options = new Array(this.getRandomInt(15, 5)).join('.').split('.') - .map((item, idx) => ({ + .map((_item, idx) => ({ value, category: `${value}${idx}`, count: this.getRandomInt(200, 100), diff --git a/components/back-top/back-top.spec.ts b/components/back-top/back-top.spec.ts index 20642a2e3d1..7e6e00aab75 100644 --- a/components/back-top/back-top.spec.ts +++ b/components/back-top/back-top.spec.ts @@ -97,7 +97,7 @@ describe('Component:nz-back-top', () => { componentObject.clickBackTop(); tick(); - expect(scrollService.getScroll(window)).toEqual(0); + expect(scrollService.getScroll()).toEqual(0); })); }); }); @@ -236,15 +236,13 @@ class TestBackTopTemplateComponent { class MockNzScrollService { mockTopOffset: number; - getScroll(el?: Element | Window, top: boolean = true): number { + getScroll(): number { return this.mockTopOffset; } scrollTo( - containerEl: Element | Window, - targetTopValue: number = 0, - easing?: {}, - callback?: {} + _containerEl: Element | Window, + targetTopValue: number = 0 ): void { this.mockTopOffset = targetTopValue; } diff --git a/components/button/nz-button.spec.ts b/components/button/nz-button.spec.ts index 1363cfbe881..f37e4cffd75 100644 --- a/components/button/nz-button.spec.ts +++ b/components/button/nz-button.spec.ts @@ -216,7 +216,7 @@ describe('button', () => { beforeEach(() => { fixture = TestBed.createComponent(NzDemoButtonSizeComponent); testComponent = fixture.debugElement.componentInstance; - buttons = fixture.debugElement.queryAll(By.directive(NzButtonComponent)).filter((item, index) => index < 6); + buttons = fixture.debugElement.queryAll(By.directive(NzButtonComponent)).filter((_, index) => index < 6); buttonGroup = fixture.debugElement.query(By.directive(NzButtonGroupComponent)); }); diff --git a/components/cascader/demo/change-on-function.ts b/components/cascader/demo/change-on-function.ts index d3da8b1412c..9b34aa13d73 100644 --- a/components/cascader/demo/change-on-function.ts +++ b/components/cascader/demo/change-on-function.ts @@ -63,7 +63,7 @@ export class NzDemoCascaderChangeOnFunctionComponent { console.log(values, this.values); } - public validate(option: any, index: number): boolean { + public validate(option: any, _index: number): boolean { const value = option.value; return ['hangzhou', 'xihu', 'nanjing', 'zhonghuamen'].indexOf(value) >= 0; } diff --git a/components/cascader/demo/custom-field-names.ts b/components/cascader/demo/custom-field-names.ts index 25952fd5fe4..2e1a91bfe14 100644 --- a/components/cascader/demo/custom-field-names.ts +++ b/components/cascader/demo/custom-field-names.ts @@ -66,7 +66,7 @@ export class NzDemoCascaderCustomFieldNamesComponent { console.log(values, this.values); } - public validate(option: any, index: number): boolean { + public validate(option: any, _index: number): boolean { const value = option.value; return ['hangzhou', 'xihu', 'nanjing', 'zhonghuamen'].indexOf(value) >= 0; } diff --git a/components/cascader/demo/modal.ts b/components/cascader/demo/modal.ts index da42264a4ef..42a44aa2090 100644 --- a/components/cascader/demo/modal.ts +++ b/components/cascader/demo/modal.ts @@ -70,7 +70,7 @@ export class NzDemoCascaderModalComponent { } handleOk($event: MouseEvent): void { - console.log('Button ok clicked!', this.values); + console.log('Button ok clicked!', this.values, $event); this.isVisible = false; } diff --git a/components/cascader/nz-cascader.component.html b/components/cascader/nz-cascader.component.html index e9c1c42b737..2f1ae67f6c1 100644 --- a/components/cascader/nz-cascader.component.html +++ b/components/cascader/nz-cascader.component.html @@ -17,8 +17,8 @@ [disabled]="nzDisabled" [nzSize]="nzSize" [(ngModel)]="inputValue" - (blur)="handleInputBlur($event)" - (focus)="handleInputFocus($event)" + (blur)="handleInputBlur()" + (focus)="handleInputFocus()" (change)="$event.stopPropagation()"> { })); it('should support custom sorter', fakeAsync(() => { testComponent.nzShowSearch = { - sorter(a: CascaderOption[], b: CascaderOption[], inputValue: string): number { + sorter(a: CascaderOption[], b: CascaderOption[], _inputValue: string): number { const l1 = a[ 0 ].label; const l2 = b[ 0 ].label; // all reversed, just to be sure it works return ('' + l1).localeCompare(l2); @@ -1865,7 +1865,7 @@ export class NzDemoCascaderDefaultComponent { onVisibleChange = jasmine.createSpy('open change'); onValueChanges = jasmine.createSpy('value change'); - fakeChangeOn = (node: any, index: number): boolean => { + fakeChangeOn = (node: any, _index: number): boolean => { return node.value === 'zhejiang'; } diff --git a/components/checkbox/nz-checkbox-group.component.ts b/components/checkbox/nz-checkbox-group.component.ts index 93220667137..ef5afa1da23 100644 --- a/components/checkbox/nz-checkbox-group.component.ts +++ b/components/checkbox/nz-checkbox-group.component.ts @@ -44,7 +44,7 @@ export class NzCheckboxGroupComponent implements ControlValueAccessor, OnInit { this.onChange(this.options); } - trackByOption(index: number, option: NzCheckBoxOptionInterface): string { + trackByOption(_index: number, option: NzCheckBoxOptionInterface): string { return option.value; } diff --git a/components/core/util/logger/logger.service.ts b/components/core/util/logger/logger.service.ts index 378f8d9544e..48aba52e231 100644 --- a/components/core/util/logger/logger.service.ts +++ b/components/core/util/logger/logger.service.ts @@ -1,4 +1,3 @@ -/* tslint:disable:no-any */ import { Inject, Injectable, InjectionToken, Optional, Provider, SkipSelf } from '@angular/core'; export const NZ_LOGGER_STATE = new InjectionToken('nz-logger-state'); // Whether print the log @@ -7,39 +6,38 @@ export const NZ_LOGGER_STATE = new InjectionToken('nz-logger-state'); / export class LoggerService { constructor(@Inject(NZ_LOGGER_STATE) private _loggerState: boolean) {} + // tslint:disable-next-line:no-any log(...args: any[]): void { if (this._loggerState) { - // console.log(...args); - console.log.apply(console, arguments); + console.log(...args); } } + // tslint:disable-next-line:no-any warn(...args: any[]): void { if (this._loggerState) { - // console.warn(...args); - console.warn.apply(console, arguments); + console.warn(...args); } } + // tslint:disable-next-line:no-any error(...args: any[]): void { if (this._loggerState) { - // console.error(...args); - console.error.apply(console, arguments); + console.error(...args); } } + // tslint:disable-next-line:no-any info(...args: any[]): void { if (this._loggerState) { - // console.log(...args); - console.log.apply(console, arguments); + console.log(...args); } } + // tslint:disable-next-line:no-any debug(...args: any[]): void { if (this._loggerState) { - // console.log('[NG-ZORRO-DEBUG]', ...args); - const arrs = Array.prototype.slice.call(arguments); - console.log.apply(console, ['[NG-ZORRO-DEBUG]'].concat(arrs)); + console.log('[NG-ZORRO-DEBUG]', ...args); } } } diff --git a/components/date-picker/date-picker.component.spec.ts b/components/date-picker/date-picker.component.spec.ts index b5101f7acef..c541d263a21 100644 --- a/components/date-picker/date-picker.component.spec.ts +++ b/components/date-picker/date-picker.component.spec.ts @@ -14,7 +14,6 @@ import en_US from '../i18n/languages/en_US'; import { NzI18nModule } from '../i18n/nz-i18n.module'; import { NzI18nService } from '../i18n/nz-i18n.service'; import { NzDatePickerModule } from './date-picker.module'; -import { PickerResultSingle } from './standard-types'; registerLocaleData(zh); @@ -565,7 +564,7 @@ describe('NzDatePickerComponent', () => { it('should support nzDisabledTime and nzShowTime.nzHideDisabledOptions', fakeAsync(() => { fixtureInstance.nzShowTime = true; - fixtureInstance.nzDisabledTime = (current: Date) => { + fixtureInstance.nzDisabledTime = () => { return { nzDisabledHours : () => [ 0, 1, 2 ], nzDisabledMinutes: () => [ 0, 1 ], @@ -814,10 +813,10 @@ class NzTestDatePickerComponent { nzSize; nzStyle; - nzOnOpenChange(d: Date): void { + nzOnOpenChange(): void { } - nzOnChange(result: PickerResultSingle): void { + nzOnChange(): void { } nzValue; diff --git a/components/date-picker/demo/disabled-date.ts b/components/date-picker/demo/disabled-date.ts index ad60a20c83e..43b62473912 100644 --- a/components/date-picker/demo/disabled-date.ts +++ b/components/date-picker/demo/disabled-date.ts @@ -55,7 +55,7 @@ export class NzDemoDatePickerDisabledDateComponent { }; }; - disabledRangeTime = (value: Date[], type: 'start' | 'end'): object => { + disabledRangeTime = (_value: Date[], type: 'start' | 'end'): object => { if (type === 'start') { return { nzDisabledHours : () => this.range(0, 60).splice(4, 20), diff --git a/components/date-picker/lib/decade/decade-panel.component.ts b/components/date-picker/lib/decade/decade-panel.component.ts index e832a98cbb7..484ac7900be 100644 --- a/components/date-picker/lib/decade/decade-panel.component.ts +++ b/components/date-picker/lib/decade/decade-panel.component.ts @@ -46,7 +46,7 @@ export class DecadePanelComponent implements OnChanges { this.gotoYear(100); } - trackPanelDecade(index: number, decadeData: PanelDecadeData): string { + trackPanelDecade(_index: number, decadeData: PanelDecadeData): string { return decadeData.content; } diff --git a/components/date-picker/lib/month/month-table.component.ts b/components/date-picker/lib/month/month-table.component.ts index 404ebe98d12..64d245242e6 100644 --- a/components/date-picker/lib/month/month-table.component.ts +++ b/components/date-picker/lib/month/month-table.component.ts @@ -33,7 +33,7 @@ export class MonthTableComponent implements OnInit, OnChanges { } } - trackPanelMonth(index: number, monthData: PanelMonthData): number { + trackPanelMonth(_index: number, monthData: PanelMonthData): number { return monthData.month; } diff --git a/components/date-picker/lib/util.spec.ts b/components/date-picker/lib/util.spec.ts index 06a81d586cc..9b2bfa4c498 100644 --- a/components/date-picker/lib/util.spec.ts +++ b/components/date-picker/lib/util.spec.ts @@ -9,8 +9,8 @@ describe('util.ts coverage supplements', () => { const disabledTime = () => { return { nzDisabledHours: () => [ 1 ], - nzDisabledMinutes: (hour) => [ 2 ], - nzDisabledSeconds: (hour, minute) => [ 3 ] + nzDisabledMinutes: () => [ 2 ], + nzDisabledSeconds: () => [ 3 ] }; }; expect(isAllowedDate(new CandyDate('2000-11-11 01:11:11'), null, disabledTime)).toBeFalsy(); diff --git a/components/date-picker/lib/year/year-panel.component.ts b/components/date-picker/lib/year/year-panel.component.ts index 4581b8ab88f..6b2e885b66d 100644 --- a/components/date-picker/lib/year/year-panel.component.ts +++ b/components/date-picker/lib/year/year-panel.component.ts @@ -63,7 +63,7 @@ export class YearPanelComponent implements OnChanges { this.gotoYear(10); } - trackPanelYear(index: number, yearData: PanelYearData): string { + trackPanelYear(_index: number, yearData: PanelYearData): string { return yearData.content; } diff --git a/components/date-picker/month-picker.component.spec.ts b/components/date-picker/month-picker.component.spec.ts index e07295b90ab..2f3f633cad3 100644 --- a/components/date-picker/month-picker.component.spec.ts +++ b/components/date-picker/month-picker.component.spec.ts @@ -11,8 +11,6 @@ import isBefore from 'date-fns/is_before'; import { dispatchMouseEvent } from '../core/testing'; import { NzInputModule } from '../input/nz-input.module'; import { NzDatePickerModule } from './date-picker.module'; -import { CandyDate } from './lib/candy-date'; -import { PickerResultSingle } from './standard-types'; registerLocaleData(zh); @@ -481,10 +479,10 @@ class NzTestMonthPickerComponent { nzSize; nzStyle; - nzOnOpenChange(d: CandyDate): void { + nzOnOpenChange(): void { } - nzOnChange(result: PickerResultSingle): void { + nzOnChange(): void { } nzValue; diff --git a/components/date-picker/range-picker.component.spec.ts b/components/date-picker/range-picker.component.spec.ts index e703b8ef079..af4984a1639 100644 --- a/components/date-picker/range-picker.component.spec.ts +++ b/components/date-picker/range-picker.component.spec.ts @@ -343,7 +343,7 @@ describe('NzRangePickerComponent', () => { it('should support nzDisabledTime and nzShowTime.nzHideDisabledOptions', fakeAsync(() => { fixtureInstance.modelValue = [ new Date('2018-11-11 11:11:11'), new Date('2018-12-12 12:12:12') ]; fixtureInstance.nzShowTime = true; - fixtureInstance.nzDisabledTime = (current: Date, partial: 'start' | 'end') => { + fixtureInstance.nzDisabledTime = (_current: Date, partial: 'start' | 'end') => { return partial === 'start' ? { nzDisabledHours: () => [ 0, 1, 2], nzDisabledMinutes: () => [ 0, 1 ], @@ -659,9 +659,9 @@ class NzTestRangePickerComponent { nzDropdownClassName; nzSize; nzStyle; - nzOnOpenChange(open: boolean): void { } + nzOnOpenChange(): void { } modelValue; - modelValueChange(d: Date): void { } + modelValueChange(): void { } nzDateRender; nzShowTime: boolean | object = false; diff --git a/components/date-picker/year-picker.component.spec.ts b/components/date-picker/year-picker.component.spec.ts index a0f249f9685..9013f3eb6b9 100644 --- a/components/date-picker/year-picker.component.spec.ts +++ b/components/date-picker/year-picker.component.spec.ts @@ -8,8 +8,6 @@ import { NoopAnimationsModule } from '@angular/platform-browser/animations'; import { dispatchMouseEvent } from '../core/testing'; import { NzInputModule } from '../input/nz-input.module'; import { NzDatePickerModule } from './date-picker.module'; -import { CandyDate } from './lib/candy-date'; -import { PickerResultSingle } from './standard-types'; describe('NzYearPickerComponent', () => { let fixture: ComponentFixture; @@ -439,10 +437,10 @@ class NzTestYearPickerComponent { nzSize; nzStyle; - nzOnOpenChange(d: CandyDate): void { + nzOnOpenChange(): void { } - nzOnChange(result: PickerResultSingle): void { + nzOnChange(): void { } nzValue; diff --git a/components/grid/nz-col.directive.ts b/components/grid/nz-col.directive.ts index 6bacc0d005b..fd46f5fba1a 100644 --- a/components/grid/nz-col.directive.ts +++ b/components/grid/nz-col.directive.ts @@ -4,10 +4,11 @@ import { ElementRef, Host, Input, - OnChanges, OnDestroy, + OnChanges, + OnDestroy, OnInit, - Optional, Renderer2, - SimpleChange + Optional, + Renderer2 } from '@angular/core'; import { Subject } from 'rxjs'; import { startWith, takeUntil } from 'rxjs/operators'; @@ -87,7 +88,7 @@ export class NzColDirective implements OnInit, OnChanges, AfterViewInit, OnDestr ) { } - ngOnChanges(changes: { [ propertyName: string ]: SimpleChange }): void { + ngOnChanges(): void { this.setClassMap(); } diff --git a/components/icon/page/index.ts b/components/icon/page/index.ts index 8fe05a4062d..161b4219bc2 100644 --- a/components/icon/page/index.ts +++ b/components/icon/page/index.ts @@ -201,7 +201,7 @@ export class NzPageDemoIconComponent implements OnInit { currentTheme = 'outline'; localeObj = locale; - trackByFn = (index: number, item: string) => { + trackByFn = (_index: number, item: string) => { return `${item}-${this.currentTheme}`; } @@ -221,7 +221,7 @@ export class NzPageDemoIconComponent implements OnInit { } private _copy(value: string): Promise { - const promise = new Promise((resolve, reject): void => { + const promise = new Promise((resolve): void => { let copyTextArea = null as HTMLTextAreaElement; try { copyTextArea = this.dom.createElement('textarea'); diff --git a/components/list/demo/vertical.ts b/components/list/demo/vertical.ts index eb260907d0e..75bf6366582 100644 --- a/components/list/demo/vertical.ts +++ b/components/list/demo/vertical.ts @@ -43,7 +43,7 @@ export class NzDemoListVerticalComponent implements OnInit { } loadData(pi: number): void { - this.data = new Array(5).fill({}).map((i, index) => { + this.data = new Array(5).fill({}).map((_, index) => { return { href: 'http://ant.design', title: `ant design part ${index} (page: ${pi})`, diff --git a/components/pagination/nz-pagination.component.ts b/components/pagination/nz-pagination.component.ts index 66713f2e8fb..c3b1dff46f9 100644 --- a/components/pagination/nz-pagination.component.ts +++ b/components/pagination/nz-pagination.component.ts @@ -85,7 +85,7 @@ export class NzPaginationComponent implements OnInit, OnDestroy, OnChanges { } } - handleKeyDown(e: KeyboardEvent, input: HTMLInputElement, clearInputValue: boolean): void { + handleKeyDown(_: KeyboardEvent, input: HTMLInputElement, clearInputValue: boolean): void { const target = input; const page = toNumber(target.value, this.nzPageIndex); if (isInteger(page) && this.isPageIndexValid(page) && page !== this.nzPageIndex) { diff --git a/components/select/nz-option-container.component.ts b/components/select/nz-option-container.component.ts index 1ecc920cd19..33ecdd50ce0 100644 --- a/components/select/nz-option-container.component.ts +++ b/components/select/nz-option-container.component.ts @@ -53,12 +53,12 @@ export class NzOptionContainerComponent implements OnDestroy, OnInit { }); } - trackLabel(index: number, option: NzOptionGroupComponent): string | TemplateRef { + trackLabel(_index: number, option: NzOptionGroupComponent): string | TemplateRef { return option.nzLabel; } // tslint:disable-next-line:no-any - trackValue(index: number, option: NzOptionComponent): any { + trackValue(_index: number, option: NzOptionComponent): any { return option.nzValue; } diff --git a/components/select/nz-select-top-control.component.ts b/components/select/nz-select-top-control.component.ts index 7ab9bc16cb4..c342a6e3453 100644 --- a/components/select/nz-select-top-control.component.ts +++ b/components/select/nz-select-top-control.component.ts @@ -85,7 +85,7 @@ export class NzSelectTopControlComponent implements OnInit, OnDestroy { } // tslint:disable-next-line:no-any - trackValue(index: number, option: NzOptionComponent): any { + trackValue(_index: number, option: NzOptionComponent): any { return option.nzValue; } diff --git a/components/skeleton/demo/list.ts b/components/skeleton/demo/list.ts index c0048c6a2da..1b148ad2e2b 100644 --- a/components/skeleton/demo/list.ts +++ b/components/skeleton/demo/list.ts @@ -28,7 +28,7 @@ import { Component } from '@angular/core'; }) export class NzDemoSkeletonListComponent { loading = true; - listData = new Array(3).fill({}).map((i, index) => { + listData = new Array(3).fill({}).map((_i, index) => { return { href: 'http://ng.ant.design', title: `ant design part ${index}`, diff --git a/components/slider/nz-slider-step.component.ts b/components/slider/nz-slider-step.component.ts index 1d0e1ce72df..3a1006d6013 100644 --- a/components/slider/nz-slider-step.component.ts +++ b/components/slider/nz-slider-step.component.ts @@ -29,7 +29,7 @@ export class NzSliderStepComponent implements OnChanges { } } - trackById(index: number, step: DisplayedStep): number { + trackById(_index: number, step: DisplayedStep): number { return step.value; } diff --git a/components/slider/nz-slider.component.ts b/components/slider/nz-slider.component.ts index 99bbb5e29af..918189e9c6a 100644 --- a/components/slider/nz-slider.component.ts +++ b/components/slider/nz-slider.component.ts @@ -110,7 +110,7 @@ export class NzSliderComponent implements ControlValueAccessor, OnInit, OnChange this.setValue(val, true); } - onValueChange(value: SliderValue): void { + onValueChange(_value: SliderValue): void { } onTouched(): void { diff --git a/components/tag/nz-tag.component.ts b/components/tag/nz-tag.component.ts index 454c9726a11..09a1881bc98 100644 --- a/components/tag/nz-tag.component.ts +++ b/components/tag/nz-tag.component.ts @@ -9,7 +9,6 @@ import { OnInit, Output, Renderer2, - SimpleChanges, ViewEncapsulation } from '@angular/core'; import { fadeMotion } from '../core/animation/fade'; @@ -93,7 +92,7 @@ export class NzTagComponent implements OnInit, OnChanges { this.updateClassMap(); } - ngOnChanges(changes: SimpleChanges): void { + ngOnChanges(): void { this.updateClassMap(); } } diff --git a/components/transfer/transfer.spec.ts b/components/transfer/transfer.spec.ts index 99f3d9cc697..3b555ce381d 100644 --- a/components/transfer/transfer.spec.ts +++ b/components/transfer/transfer.spec.ts @@ -385,13 +385,13 @@ class TestTransferComponent implements OnInit { this.nzDataSource = ret; } - search(ret: {}): void { + search(): void { } - select(ret: {}): void { + select(): void { } - change(ret: {}): void { + change(): void { } } diff --git a/components/tree-select/nz-tree-select.component.ts b/components/tree-select/nz-tree-select.component.ts index 8eca3277cc6..e8715d056c8 100644 --- a/components/tree-select/nz-tree-select.component.ts +++ b/components/tree-select/nz-tree-select.component.ts @@ -219,6 +219,7 @@ export class NzTreeSelectComponent implements ControlValueAccessor, OnInit, Afte } registerOnTouched(fn: () => void): void { + this.onTouched = fn; } @HostListener('click') diff --git a/components/tree/demo/directory.ts b/components/tree/demo/directory.ts index 6248b704496..66ae28054e8 100644 --- a/components/tree/demo/directory.ts +++ b/components/tree/demo/directory.ts @@ -125,7 +125,7 @@ export class NzDemoTreeDirectoryComponent { this.dropdown = this.nzDropdownService.create($event, template); } - selectDropdown(type: string): void { + selectDropdown(_type: string): void { this.dropdown.close(); // do something } diff --git a/components/tree/nz-tree-node.component.ts b/components/tree/nz-tree-node.component.ts index f34998302be..5c6f63ad73c 100644 --- a/components/tree/nz-tree-node.component.ts +++ b/components/tree/nz-tree-node.component.ts @@ -11,7 +11,6 @@ import { OnInit, Output, Renderer2, - SimpleChange, TemplateRef, ViewChild } from '@angular/core'; @@ -432,7 +431,7 @@ export class NzTreeNodeComponent implements OnInit, OnChanges, OnDestroy { this.setClassMap(); } - ngOnChanges(changes: { [ propertyName: string ]: SimpleChange }): void { + ngOnChanges(): void { this.setClassMap(); } diff --git a/components/tree/nz-tree.spec.ts b/components/tree/nz-tree.spec.ts index 9ac76077bb9..27d29d5dd1c 100644 --- a/components/tree/nz-tree.spec.ts +++ b/components/tree/nz-tree.spec.ts @@ -8,7 +8,6 @@ import { of, Observable } from 'rxjs'; import { dispatchMouseEvent, dispatchTouchEvent } from '../core/testing'; import { NzIconTestModule } from '../icon/nz-icon-test.module'; -import { NzFormatBeforeDropEvent, NzFormatEmitEvent } from './interface'; import { NzTreeNode } from './nz-tree-node'; import { NzTreeComponent } from './nz-tree.component'; import { NzTreeModule } from './nz-tree.module'; @@ -481,7 +480,7 @@ describe('nz-tree', () => { it('test drag event nzBeforeDrop', () => { const dragNode = treeElement.querySelector('[title=\'0-2\']'); let dropNode = treeElement.querySelector('[title=\'0-1\']'); - treeInstance.beforeDrop = (arg: NzFormatBeforeDropEvent): Observable => { + treeInstance.beforeDrop = (): Observable => { return of(true); }; fixture.detectChanges(); @@ -627,8 +626,7 @@ export class NzTestTreeBasicControlledComponent { isLeaf : true } ]; - nzEvent(event: NzFormatEmitEvent): void { - // console.log(event.eventName, event); + nzEvent(): void { } } @@ -710,22 +708,22 @@ export class NzTestTreeDraggableComponent { } ]; beforeDrop; - onDragStart(event: NzFormatEmitEvent): void { + onDragStart(): void { } - onDragEnter(event: NzFormatEmitEvent): void { + onDragEnter(): void { } - onDragOver(event: NzFormatEmitEvent): void { + onDragOver(): void { } - onDragLeave(event: NzFormatEmitEvent): void { + onDragLeave(): void { } - onDrop(event: NzFormatEmitEvent): void { + onDrop(): void { } - onDragEnd(event: NzFormatEmitEvent): void { + onDragEnd(): void { } } diff --git a/components/upload/demo/custom-request.ts b/components/upload/demo/custom-request.ts index 9f8a96c349c..b6d6dd3dc98 100644 --- a/components/upload/demo/custom-request.ts +++ b/components/upload/demo/custom-request.ts @@ -53,7 +53,7 @@ export class NzDemoUploadCustomRequestComponent { const size = item.file.size; const chunkSize = parseInt((size / 3) + '', 10); const maxChunk = Math.ceil(size / chunkSize); - const reqs = Array(maxChunk).fill(0).map((v: {}, index: number) => { + const reqs = Array(maxChunk).fill(0).map((_: {}, index: number) => { const start = index * chunkSize; let end = start + chunkSize; if (size - end < 0) { @@ -69,7 +69,7 @@ export class NzDemoUploadCustomRequestComponent { }); return this.http.request(req); }); - return forkJoin(...reqs).subscribe(resules => { + return forkJoin(...reqs).subscribe(() => { // 处理成功 item.onSuccess({}, item.file, event); }, (err) => { diff --git a/components/upload/demo/manually.ts b/components/upload/demo/manually.ts index 1fb3acd9f6c..6a2048bd866 100644 --- a/components/upload/demo/manually.ts +++ b/components/upload/demo/manually.ts @@ -44,12 +44,12 @@ export class NzDemoUploadManuallyComponent { .request(req) .pipe(filter(e => e instanceof HttpResponse)) .subscribe( - (event: {}) => { + () => { this.uploading = false; this.fileList = []; this.msg.success('upload successfully.'); }, - err => { + () => { this.uploading = false; this.msg.error('upload failed.'); } diff --git a/components/upload/upload.spec.ts b/components/upload/upload.spec.ts index 3c604b70830..47a1b2fdfa1 100644 --- a/components/upload/upload.spec.ts +++ b/components/upload/upload.spec.ts @@ -16,7 +16,7 @@ import { NzIconTestModule } from '../icon/nz-icon-test.module'; import { NzProgressModule } from '../progress/nz-progress.module'; import { NzToolTipModule } from '../tooltip/nz-tooltip.module'; -import { ShowUploadListInterface, UploadChangeParam, UploadFile, UploadFilter, UploadListType, UploadType, UploadXHRArgs, ZipButtonOptions } from './interface'; +import { ShowUploadListInterface, UploadChangeParam, UploadFile, UploadFilter, UploadListType, UploadType, ZipButtonOptions } from './interface'; import { NzUploadBtnComponent } from './nz-upload-btn.component'; import { NzUploadListComponent } from './nz-upload-list.component'; import { NzUploadComponent } from './nz-upload.component'; @@ -194,7 +194,7 @@ describe('upload', () => { describe('property', () => { describe('[nzData]', () => { it('should custom form data vis function', () => { - instance.nzData = (file: any) => { + instance.nzData = () => { return { a: 1 }; }; fixture.detectChanges(); @@ -217,7 +217,7 @@ describe('upload', () => { it('should comst fileter', () => { instance.nzFilter = [ - { name: 'custom', fn: (a: any) => [] } + { name: 'custom', fn: () => [] } ]; fixture.detectChanges(); expect(instance._beforeUploadList.length).toBe(0); @@ -234,7 +234,7 @@ describe('upload', () => { describe('[nzHeaders]', () => { it('should custom form data vis function', () => { - instance.nzHeaders = (file: any) => { + instance.nzHeaders = () => { return { a: '1' }; }; fixture.detectChanges(); @@ -296,14 +296,14 @@ describe('upload', () => { describe('using observable', () => { it('can return true', () => { spyOn(instance, 'nzChange'); - instance.beforeUpload = (file: UploadFile, fileList: UploadFile[]): Observable => of(true); + instance.beforeUpload = (): Observable => of(true); fixture.detectChanges(); pageObject.postSmall(); expect(instance.nzChange).toHaveBeenCalled(); }); it('can return same file', () => { let ret = false; - instance.beforeUpload = (file: UploadFile, fileList: UploadFile[]): Observable => { + instance.beforeUpload = (file: UploadFile): Observable => { ret = true; return of(file); }; @@ -313,7 +313,7 @@ describe('upload', () => { }); it('can return a string file', () => { let ret = false; - instance.beforeUpload = (file: UploadFile, fileList: UploadFile[]): Observable => { + instance.beforeUpload = (): Observable => { ret = true; return of('file'); }; @@ -323,7 +323,7 @@ describe('upload', () => { }); it('can return a blob file', () => { let ret = false; - instance.beforeUpload = (file: UploadFile, fileList: UploadFile[]): Observable => { + instance.beforeUpload = (): Observable => { ret = true; return of(new Blob([JSON.stringify(1, null, 2)], {type : 'application/json'})); }; @@ -333,7 +333,7 @@ describe('upload', () => { }); it('cancel upload when returan a false value', () => { expect(instance._nzChange).toBeUndefined(); - instance.beforeUpload = (file: UploadFile, fileList: UploadFile[]): Observable => { + instance.beforeUpload = (): Observable => { return of(false); }; fixture.detectChanges(); @@ -344,7 +344,7 @@ describe('upload', () => { let warnMsg = ''; console.warn = jasmine.createSpy().and.callFake(res => warnMsg = res); expect(instance._nzChange).toBeUndefined(); - instance.beforeUpload = (file: UploadFile, fileList: UploadFile[]): Observable => { + instance.beforeUpload = (): Observable => { return throwError(''); }; fixture.detectChanges(); @@ -436,7 +436,7 @@ describe('upload', () => { instance.nzFilter = [ { name: 'f1', - fn: (fileList: UploadFile[]) => { + fn: () => { return new Observable((observer: Observer) => { observer.error('filter error'); }); @@ -498,7 +498,7 @@ describe('upload', () => { }); it('should be return a Observable includes a delay operation', (done: () => void) => { const DELAY = 20; - instance.onRemove = (file: UploadFile) => of(true).pipe(delay(DELAY)); + instance.onRemove = () => of(true).pipe(delay(DELAY)); fixture.detectChanges(); expect(dl.queryAll(By.css('.anticon-close')).length).toBe(INITCOUNT); dl.query(By.css('.anticon-close')).nativeElement.click(); @@ -821,15 +821,15 @@ describe('upload', () => { describe('[genThumb]', () => { class MockFR { result = '1'; - onloadend(dataUrl: string): void { } + onloadend(): void { } readAsDataURL(): void { - this.onloadend('1'); + this.onloadend(); } } it('should be generate thumb when is valid image data', () => { spyOn(window as any, 'FileReader').and.returnValue(new MockFR()); instance.listType = 'picture'; - instance.items = [ { originFileObj: new File([''], '1.png', { type: 'image' }), thumbUrl: undefined } ]; + instance.items = [ { originFileObj: new File([''], '1.png', { type: 'image' }), thgitumbUrl: undefined } ]; fixture.detectChanges(); expect(instance.items[0].thumbUrl).toBe('1'); }); @@ -1097,7 +1097,7 @@ describe('upload', () => { multiple: true, withCredentials: true, beforeUpload: () => true, - onStart: (file: {}) => {}, + onStart: () => {}, onProgress: () => {}, onSuccess: () => {}, onError: () => {} @@ -1176,7 +1176,7 @@ describe('upload', () => { it('should be warn "Must return Subscription type in [nzCustomRequest] property"', () => { let warnMsg = ''; console.warn = jasmine.createSpy().and.callFake(res => warnMsg = res); - comp.options.customRequest = ((item: UploadXHRArgs) => { }) as any; + comp.options.customRequest = (() => {}) as any; comp.onChange(PNGSMALL as any); expect(warnMsg).toContain(`Must return Subscription type`); }); @@ -1228,7 +1228,7 @@ class TestUploadComponent { nzAction = '/upload'; _beforeUpload = false; _beforeUploadList: UploadFile[] = []; - beforeUpload: any = (file: UploadFile, fileList: UploadFile[]): any => { + beforeUpload: any = (_file: UploadFile, fileList: UploadFile[]): any => { this._beforeUpload = true; this._beforeUploadList = fileList; return true; @@ -1246,11 +1246,11 @@ class TestUploadComponent { nzShowButton = true; nzWithCredentials = false; _onPreview = false; - onPreview = (file: UploadFile): void => { + onPreview = (): void => { this._onPreview = true; } _onRemove = false; - onRemove: (file: UploadFile) => boolean | Observable = (file: UploadFile): boolean => { + onRemove: (file: UploadFile) => boolean | Observable = (): boolean => { this._onRemove = true; return true; } @@ -1300,11 +1300,11 @@ class TestUploadListComponent { showRemoveIcon: true }; _onPreview = false; - onPreview = (file: UploadFile): void => { + onPreview = (): void => { this._onPreview = true; } _onRemove = false; - onRemove: any = (file: UploadFile): void => { + onRemove: any = (): void => { this._onRemove = true; } } diff --git a/scripts/site/_site/doc/app/share/nz-codebox/nz-codebox.component.ts b/scripts/site/_site/doc/app/share/nz-codebox/nz-codebox.component.ts index 48c0ea45150..f2c3c9ccca1 100644 --- a/scripts/site/_site/doc/app/share/nz-codebox/nz-codebox.component.ts +++ b/scripts/site/_site/doc/app/share/nz-codebox/nz-codebox.component.ts @@ -114,7 +114,7 @@ export class NzCodeBoxComponent { copy(value: string): Promise { const promise = new Promise( - (resolve, reject): void => { + (resolve): void => { let copyTextArea = null as HTMLTextAreaElement; try { copyTextArea = this.dom.createElement('textarea'); diff --git a/tsconfig.json b/tsconfig.json index 2d511e71e27..b13ba89006c 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -16,6 +16,7 @@ "es2017", "dom" ], + "noUnusedParameters": true, "noUnusedLocals": true, "skipLibCheck": true }