Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing epsilon on SGHMC? #1

Open
botev opened this issue Nov 23, 2018 · 3 comments
Open

Missing epsilon on SGHMC? #1

botev opened this issue Nov 23, 2018 · 3 comments

Comments

@botev
Copy link

botev commented Nov 23, 2018

Hi,
Thanks to the authors for the nice read.
I have a question for these lines which indicate that you are doing theta_t = theta_t + v_t while the correct definition in SGHMC is theta_t = theta_t + eta_t * v_t (ignoring the Mass as it seems here its assumed to be unity).
I have not used Pytorch so maybe I'm missunderstanding something?

@hsvgbkhgbv
Copy link
Owner

hsvgbkhgbv commented Nov 23, 2018

Hi,
Thank you for your question.
We fuse eta_t to the line above the line that you point out.
I wish this can answer your question.

@botev
Copy link
Author

botev commented Nov 23, 2018

Do you mean that 'module.eta_theta' is somehow the product of the two discretisation constants and the velocity is actually velocity times eta_t?

@hsvgbkhgbv
Copy link
Owner

Yes, it is but this eta_theta may absorb the eta_t that you mentioned.
When we implement this algorithm, to be consistent to the symbols used for our own method working on sampling parameters for partial observations, we reformulate the hyperparameters.
If you would like some more details, please read our paper. If you are still doubted, please contact r.luo@cs.ucl.ac.uk for more specific answers.
It that happy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants