add hotgym data for NuPIC example #69
Conversation
| // buffer size (in rows/items) used for DyGraph streaming, default 10000 | ||
| // each batch existing values are dropped, new WINDOW_SIZE is painted. Graph will "move to the right". | ||
| // -1 : data never dropped, just append. Graph will "shrink". | ||
| WINDOW_SIZE : 10000, |
There was a problem hiding this comment.
this is BUFFER_SIZE now.
|
@jefffohl this is ready for your review. Functionality is complete. Resolves a couple of issues. |
|
@rhyolight this branch is ready to test, if you wanna give it a shot. |
|
@breznak where exactly did you get that data file? The predictions look bad. |
|
Chart looks good to me 👍 |
Thanks. [discussed on chat, the file is from "official nupic" hotgym example.] |
|
Thanks @breznak - can you explain how |
it is not, actually. I've tried to cross that out in the PR description, the problem was caused by the |
| @@ -221,19 +231,17 @@ angular.module('app').controller('appCtrl', ['$scope', '$http', '$timeout', 'app | |||
| worker: false, // multithreaded, !but does NOT work with other libs in app.js or streaming | |||
| comments: "#", | |||
| chunk: function(chunk, parser) { | |||
| if (!firstChunkComplete) { | |||
| streamParser = parser; | |||
There was a problem hiding this comment.
The reason I was putting this here was to avoid assigning parser to streamParser this over and over again. I don't know how expensive it is to keep assigning the same thing over and over though - probably less than doing the check for firstChunkComplete? If you want to remove firstChunkComplete you can. Note that it is initialized above.
There was a problem hiding this comment.
I guess it depends on the interpreter etc, but it seems like it's nothing compared to nothing:
https://stackoverflow.com/questions/4043455/which-costs-more-while-looping-assignment-or-an-if-statement
For which I'd prefer the simpler approach.
|
👍 Looks good @breznak. Thanks! One thing that really needs updates is the notifications system. We have a lot of user feedback to show now that tell the user how the app is interpreting the data. I am starting to think we need a scrolling console or something similar in the UI. Having all the alerts pile up the way they are now is not working well. We should probably have that addressed before release v1.0 |
add hotgym data for NuPIC example
thewindowingseems to cause problems, I'd suggest disabling for now until we need it in online monitoring PR (eg anomalies don't highlight with it, probably should add UI control so users can choose, as the hotgym example gets truncated too, ...)Fixes #10
Fixes #70